Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mark github workspace as safe #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hellodw
Copy link

@hellodw hellodw commented Aug 21, 2023

Hello @norio-nomura
First of all thanks a lot for your work!

Fixed bug for issue #43
Check it out and have a nice day!

@yannpom
Copy link

yannpom commented Nov 14, 2023

As this PR is not being merged. Here is a fork with this fix: https://github.com/yannpom/action-swiftlint

Working great with this GH Action: .github/workflows/swiftlint.yml

name: SwiftLint

on:
  pull_request:
    paths:
      - '.github/workflows/swiftlint.yml'
      - '.swiftlint.yml'
      - '**/*.swift'

jobs:
  SwiftLint:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
        with:
          fetch-depth: 0  # Fetches all history for all branches and tags
      Enable this Step in the next PR
      - name: GitHub Action for SwiftLint (Strict on files changed in the PR)
        uses: yannpom/action-swiftlint@v1
        env:
          DIFF_BASE: ${{ github.base_ref }}
        with:
          args: --strict

@joshgordon1
Copy link

As this PR is not being merged. Here is a fork with this fix: https://github.com/yannpom/action-swiftlint

Working great with this GH Action: .github/workflows/swiftlint.yml

name: SwiftLint

on:
  pull_request:
    paths:
      - '.github/workflows/swiftlint.yml'
      - '.swiftlint.yml'
      - '**/*.swift'

jobs:
  SwiftLint:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
        with:
          fetch-depth: 0  # Fetches all history for all branches and tags
      Enable this Step in the next PR
      - name: GitHub Action for SwiftLint (Strict on files changed in the PR)
        uses: yannpom/action-swiftlint@v1
        env:
          DIFF_BASE: ${{ github.base_ref }}
        with:
          args: --strict

Were you able to use this with a specific filepath for a custom stylelint file?

@cerezo074
Copy link

Thanks @hellodw and @yannpom for your help, but even using the action forked by @yannpom in my case the step didn't comment those modified files in my PR, instead it did comment others that aren't part of the committed changes. I ran the linter locally just to make sure there isn't error with the config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants