[NC | NSFS] add support for DMAPI xattr based GLACIER storage class #8028
+388
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangledbytes
force-pushed
the
utkarsh/feat/dmapi-based-glacier
branch
from
1af7dee
to
c92287a
Compare
guymguym
requested changes
May 8, 2024
tangledbytes
force-pushed
the
utkarsh/feat/dmapi-based-glacier
branch
from
c92287a
to
b9278f9
Compare
guymguym
requested changes
May 29, 2024
src/native/fs/fs_napi.cpp
Outdated
Comment on lines
238
to
242
| const static std::vector<std::string> GPFS_XATTRS{ | ||
| GPFS_ENCRYPTION_XATTR_NAME, | ||
| GPFS_DMAPI_XATTR_TAPE_INDICATOR, | ||
| GPFS_DMAPI_XATTR_TAPE_PREMIG, | ||
| }; |
There was a problem hiding this comment.
this list is going to be used in every stat call... I think we want to optimize it so that it will not include dmapi xattrs when config.NSFS_GLACIER_USE_DMAPI is false.
For this I would add this to namespace_fs in prepare_fs_context to set fs_context.use_dmapi = config.NSFS_GLACIER_USE_DMAPI. This is also needed in manage_nsfs_glacier in force_gpfs_fs_context ().
Then back here in fs_napi you can store it in FSWorker and pass it to get_fd_gpfs_xattr... a long way... but it would save a these two calls when the config is false which I think is worth the coding effort.
tangledbytes
force-pushed
the
utkarsh/feat/dmapi-based-glacier
branch
from
b9278f9
to
b57d9dd
Compare
tangledbytes
force-pushed
the
utkarsh/feat/dmapi-based-glacier
branch
from
b57d9dd
to
fb773a6
Compare
tangledbytes
force-pushed
the
utkarsh/feat/dmapi-based-glacier
branch
2 times, most recently
from
ea2470c
to
9f4a5c9
Compare
Signed-off-by: Utkarsh Srivastava <[email protected]>
tangledbytes
force-pushed
the
utkarsh/feat/dmapi-based-glacier
branch
from
9f4a5c9
to
73d6f2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This PR adds support expands the GLACIER storage class by automatically deriving the state of the object if
config.NSFS_GLACIER_USE_DMAPI = true(not the default).Testing Instructions:
./node_modules/.bin/mocha src/test/unit_tests/test_nsfs_glacier_backend.js