-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typescript bindings maintenance #2363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: limez <[email protected]>
Signed-off-by: limez <[email protected]>
Signed-off-by: limez <[email protected]>
Signed-off-by: limez <[email protected]>
Signed-off-by: limez <[email protected]>
Signed-off-by: limez <[email protected]>
iimez
changed the title
simpler typescript bindings build
typescript bindings maintenance
May 21, 2024
Signed-off-by: limez <[email protected]>
Signed-off-by: jacob <[email protected]> update typings Signed-off-by: jacob <[email protected]>
Signed-off-by: jacob <[email protected]>
…arts Signed-off-by: limez <[email protected]>
… in ci Signed-off-by: limez <[email protected]>
Signed-off-by: limez <[email protected]>
…fallback easier testable Signed-off-by: limez <[email protected]>
…the others Signed-off-by: limez <[email protected]>
Signed-off-by: Jacob Nguyen <[email protected]>
Signed-off-by: limez <[email protected]>
jacoobes
requested changes
May 29, 2024
Signed-off-by: limez <[email protected]>
Signed-off-by: limez <[email protected]>
Signed-off-by: limez <[email protected]>
Signed-off-by: limez <[email protected]>
Signed-off-by: limez <[email protected]>
jacoobes
approved these changes
Jun 3, 2024
@jacoobes Please use shorter merge commit messages in the future - even a blank merge description is better than adding two pages of text to the top of the |
Oop, thanks!
…On Mon, Jun 3, 2024 at 2:10 PM Jared Van Bortel ***@***.***> wrote:
@jacoobes <https://github.com/jacoobes> Please use shorter merge commit
messages in the future - even a blank merge description is better than
adding two pages of text to the top of the git log. Refined GitHub
<https://github.com/refined-github/refined-github> even clears the
description by default. Thanks.
—
Reply to this email directly, view it on GitHub
<#2363 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASJS6O3HHAKRZL5LEUF5KQ3ZFS5TDAVCNFSM6AAAAABH5EJ5QCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVHEZTEMBQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
cebtenzzre
added a commit
that referenced
this pull request
Jun 3, 2024
As discussed on Discord, this PR was not ready to be merged. CI fails on it. This reverts commit a602f7f. Signed-off-by: Jared Van Bortel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
nCtx
on completions.so
files with the correct build type.Release
build type.LLModel:load
andLLModel:initGpu
methods so its easier to copy the loading and backend-picking logic of the CUDA Backend PR. I also renamed a few things for consistency.nThreads
in theLoadModelOptions
, previously it had to be configured via setThreadCount.nGpuLayers
as alias forngl
to theLoadModelOptions
.test:ci
script. Can switch CI config back toyarn test
if inference in CI is possible.node-gyp-build
is still working. Changed the build setup a bit to include aassert-backend-sources.js
script that facilitates easier testing of the fallback during development. This also allows us to get rid of the second bindings.gyp config.Breaking changes
CompletionOptions
onReponseToken(tokenId, text)
callback has been changed toonResponseTokens({ tokenIds, text })
(Note the plural.). This is related to the streamed emoji decoding / multi token character issue.Issue ticket number and link
#2326