-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP : First draft for #31 #41
base: master
Are you sure you want to change the base?
Conversation
Thanks for the change, but this is not exactly what I meant. There are no fixed names called ":site" or ":one", these are just example variable names, like "foo" or "hamburger". Importantly, you can make more of them. Imagine you're making a news site generator, you could have one single unique topic ordering for the main articles and one unique topic ordering for the sidebar. (so So |
Oh!! |
I agree, sometimes it's difficult to think of a name because there will be only one of those things. That's why we use the "one" or "site" placeholder name. However, I would still require them to give a note, just to avoid overly cryptic special-characters-only syntax. We don't want to end up as Perl :-) |
👍 |
@fdb I am facing some problem with making |
Huh why? Is this a regex thing? |
I don't think so.
So I made a new
|
Okay, I think I figured this out. I will have to include the case for |
@fdb Does this look similar to what you actually wanted? |
@kunal-mohta I appreciate the work, but it's not ready yet: the ordering still needs to happen and some of the code is a bit sloppy (ie. double equals instead of triple equals — read why). I would ask to please only make a PR when you have a finished, working implementation. We're a small research team and we don't have the resources to guide this process every step of the way. |
@fdb I understand. Sorry for the inconvenience. |
This is a first draft for #31
I have used the syntax as
topic:site
because~
is an invalid character. If you still want it to be used, we can change it to a valid character.Currently I have not randomized the order, instead I have predefined the order in the array
randomOrder
. I will randomize it when other things are finalized.