Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][LowerToAIE] fix for op could not fold repetition counts #1055

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

newling
Copy link
Contributor

@newling newling commented Jan 23, 2025

I think this is a fix for

<unknown>:0: error: 'amdaie.npu.circular_dma_cpy_nd' op could not fold repetition counts

that I see for some transposed matmuls with the new pack-peel pipeline. I need to add a test, and do some more ironing.

This could probably be avoided by more serious canonicalization of sizes/strides/offsets -- what's happened I think is that the lower-to-aie pass is assuming a stride-0 leading dimension, but it's been removed somewhere.

@newling newling force-pushed the fold_repetition_count_fix branch 2 times, most recently from 72ea806 to 7343968 Compare January 24, 2025 20:52
@newling newling force-pushed the fold_repetition_count_fix branch from 7343968 to 647ebcd Compare January 24, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant