-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove calendar top bar #8379
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Uffizzi Preview |
4c228fb
to
9fa283d
Compare
8da89b2
to
bb07754
Compare
bb3e8d0
to
2a93562
Compare
a9e0b2f
to
2de3e3b
Compare
2b13368
to
fde2e23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
packages/nc-gui/lang/en.json
is excluded by!**/*.json
Files selected for processing (33)
- packages/nc-gui/assets/style.scss (1 hunks)
- packages/nc-gui/components/nc/DateWeekSelector.vue (8 hunks)
- packages/nc-gui/components/nc/MonthYearSelector.vue (5 hunks)
- packages/nc-gui/components/smartsheet/Toolbar.vue (2 hunks)
- packages/nc-gui/components/smartsheet/calendar/DayView/DateField.vue (1 hunks)
- packages/nc-gui/components/smartsheet/calendar/DayView/DateTimeField.vue (4 hunks)
- packages/nc-gui/components/smartsheet/calendar/MonthView.vue (7 hunks)
- packages/nc-gui/components/smartsheet/calendar/SideMenu.vue (6 hunks)
- packages/nc-gui/components/smartsheet/calendar/WeekView/DateField.vue (1 hunks)
- packages/nc-gui/components/smartsheet/calendar/WeekView/DateTimeField.vue (7 hunks)
- packages/nc-gui/components/smartsheet/calendar/YearView.vue (2 hunks)
- packages/nc-gui/components/smartsheet/calendar/index.vue (5 hunks)
- packages/nc-gui/components/smartsheet/toolbar/Calendar/ActiveView.vue (1 hunks)
- packages/nc-gui/components/smartsheet/toolbar/Calendar/Header.vue (1 hunks)
- packages/nc-gui/components/smartsheet/toolbar/Calendar/Mode.vue (3 hunks)
- packages/nc-gui/components/smartsheet/toolbar/Calendar/Range.vue (2 hunks)
- packages/nc-gui/components/smartsheet/toolbar/Calendar/Today.vue (1 hunks)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue (1 hunks)
- packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue (1 hunks)
- packages/nc-gui/components/smartsheet/toolbar/GroupByMenu.vue (1 hunks)
- packages/nc-gui/components/smartsheet/toolbar/RowHeight.vue (2 hunks)
- packages/nc-gui/components/smartsheet/toolbar/SearchData.vue (2 hunks)
- packages/nc-gui/components/smartsheet/toolbar/SortListMenu.vue (3 hunks)
- packages/nc-gui/components/smartsheet/toolbar/StackedBy.vue (3 hunks)
- packages/nc-gui/composables/useCalendarViewStore.ts (13 hunks)
- packages/nc-gui/composables/useViewColumns.ts (1 hunks)
- tests/playwright/pages/Dashboard/Calendar/CalendarSideMenu.ts (2 hunks)
- tests/playwright/pages/Dashboard/Calendar/CalendarWeekDateTime.ts (1 hunks)
- tests/playwright/pages/Dashboard/Calendar/CalendarYear.ts (1 hunks)
- tests/playwright/pages/Dashboard/Calendar/index.ts (4 hunks)
- tests/playwright/pages/Dashboard/common/Toolbar/CalendarViewMode.ts (1 hunks)
- tests/playwright/pages/Dashboard/common/Toolbar/index.ts (5 hunks)
- tests/playwright/tests/db/views/viewCalendar.spec.ts (6 hunks)
Files skipped from review as they are similar to previous changes (32)
- packages/nc-gui/assets/style.scss
- packages/nc-gui/components/nc/DateWeekSelector.vue
- packages/nc-gui/components/nc/MonthYearSelector.vue
- packages/nc-gui/components/smartsheet/Toolbar.vue
- packages/nc-gui/components/smartsheet/calendar/DayView/DateField.vue
- packages/nc-gui/components/smartsheet/calendar/DayView/DateTimeField.vue
- packages/nc-gui/components/smartsheet/calendar/MonthView.vue
- packages/nc-gui/components/smartsheet/calendar/SideMenu.vue
- packages/nc-gui/components/smartsheet/calendar/WeekView/DateField.vue
- packages/nc-gui/components/smartsheet/calendar/WeekView/DateTimeField.vue
- packages/nc-gui/components/smartsheet/calendar/YearView.vue
- packages/nc-gui/components/smartsheet/toolbar/Calendar/ActiveView.vue
- packages/nc-gui/components/smartsheet/toolbar/Calendar/Header.vue
- packages/nc-gui/components/smartsheet/toolbar/Calendar/Mode.vue
- packages/nc-gui/components/smartsheet/toolbar/Calendar/Range.vue
- packages/nc-gui/components/smartsheet/toolbar/Calendar/Today.vue
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue
- packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue
- packages/nc-gui/components/smartsheet/toolbar/GroupByMenu.vue
- packages/nc-gui/components/smartsheet/toolbar/RowHeight.vue
- packages/nc-gui/components/smartsheet/toolbar/SearchData.vue
- packages/nc-gui/components/smartsheet/toolbar/SortListMenu.vue
- packages/nc-gui/components/smartsheet/toolbar/StackedBy.vue
- packages/nc-gui/composables/useCalendarViewStore.ts
- packages/nc-gui/composables/useViewColumns.ts
- tests/playwright/pages/Dashboard/Calendar/CalendarSideMenu.ts
- tests/playwright/pages/Dashboard/Calendar/CalendarWeekDateTime.ts
- tests/playwright/pages/Dashboard/Calendar/CalendarYear.ts
- tests/playwright/pages/Dashboard/Calendar/index.ts
- tests/playwright/pages/Dashboard/common/Toolbar/CalendarViewMode.ts
- tests/playwright/pages/Dashboard/common/Toolbar/index.ts
- tests/playwright/tests/db/views/viewCalendar.spec.ts
Additional comments not posted (1)
packages/nc-gui/components/smartsheet/calendar/index.vue (1)
22-22
: Ensure proper error handling for external calls in$e
.
98c115e
to
5ffc28c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (2)
packages/nc-gui/components/smartsheet/calendar/index.vue (2)
5-5
: Consider adding a comment to explain the purpose of the$e
event trigger for better maintainability.Adding a brief comment can help other developers understand the purpose of this event trigger.
117-117
: Please ensure that ARIA roles and responsive design features are implemented in the calendar wrapper to enhance accessibility and user experience.Implementing ARIA roles and ensuring responsive design will improve accessibility and usability.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
packages/nc-gui/lang/en.json
is excluded by!**/*.json
Files selected for processing (48)
- packages/nc-gui/assets/style.scss (2 hunks)
- packages/nc-gui/components/cmd-k/index.vue (1 hunks)
- packages/nc-gui/components/cmd-l/index.vue (1 hunks)
- packages/nc-gui/components/dashboard/TreeView/CreateViewBtn.vue (1 hunks)
- packages/nc-gui/components/dashboard/TreeView/ViewsNode.vue (1 hunks)
- packages/nc-gui/components/dlg/ViewCreate.vue (8 hunks)
- packages/nc-gui/components/dlg/ViewDelete.vue (1 hunks)
- packages/nc-gui/components/nc/DateWeekSelector.vue (10 hunks)
- packages/nc-gui/components/nc/Divider.vue (1 hunks)
- packages/nc-gui/components/nc/Modal.vue (1 hunks)
- packages/nc-gui/components/nc/MonthYearSelector.vue (4 hunks)
- packages/nc-gui/components/nc/Select.vue (1 hunks)
- packages/nc-gui/components/smartsheet/Toolbar.vue (2 hunks)
- packages/nc-gui/components/smartsheet/calendar/DayView/DateField.vue (4 hunks)
- packages/nc-gui/components/smartsheet/calendar/DayView/DateTimeField.vue (5 hunks)
- packages/nc-gui/components/smartsheet/calendar/MonthView.vue (10 hunks)
- packages/nc-gui/components/smartsheet/calendar/SideMenu.vue (7 hunks)
- packages/nc-gui/components/smartsheet/calendar/WeekView/DateField.vue (3 hunks)
- packages/nc-gui/components/smartsheet/calendar/WeekView/DateTimeField.vue (9 hunks)
- packages/nc-gui/components/smartsheet/calendar/YearView.vue (4 hunks)
- packages/nc-gui/components/smartsheet/calendar/index.vue (4 hunks)
- packages/nc-gui/components/smartsheet/toolbar/Calendar/ActiveView.vue (1 hunks)
- packages/nc-gui/components/smartsheet/toolbar/Calendar/Header.vue (1 hunks)
- packages/nc-gui/components/smartsheet/toolbar/Calendar/Mode.vue (1 hunks)
- packages/nc-gui/components/smartsheet/toolbar/Calendar/Range.vue (4 hunks)
- packages/nc-gui/components/smartsheet/toolbar/Calendar/Today.vue (1 hunks)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue (1 hunks)
- packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue (1 hunks)
- packages/nc-gui/components/smartsheet/toolbar/GroupByMenu.vue (1 hunks)
- packages/nc-gui/components/smartsheet/toolbar/RowHeight.vue (2 hunks)
- packages/nc-gui/components/smartsheet/toolbar/SearchData.vue (2 hunks)
- packages/nc-gui/components/smartsheet/toolbar/SortListMenu.vue (3 hunks)
- packages/nc-gui/components/smartsheet/toolbar/StackedBy.vue (3 hunks)
- packages/nc-gui/components/smartsheet/topbar/SelectMode.vue (2 hunks)
- packages/nc-gui/components/tabs/Smartsheet.vue (1 hunks)
- packages/nc-gui/composables/useCalendarViewStore.ts (12 hunks)
- packages/nc-gui/composables/useViewColumns.ts (1 hunks)
- packages/nc-gui/utils/iconUtils.ts (3 hunks)
- packages/nc-gui/windi.config.ts (1 hunks)
- tests/playwright/pages/Dashboard/Calendar/CalendarSideMenu.ts (2 hunks)
- tests/playwright/pages/Dashboard/Calendar/CalendarWeekDateTime.ts (3 hunks)
- tests/playwright/pages/Dashboard/Calendar/CalendarYear.ts (1 hunks)
- tests/playwright/pages/Dashboard/Calendar/index.ts (4 hunks)
- tests/playwright/pages/Dashboard/ViewSidebar/index.ts (1 hunks)
- tests/playwright/pages/Dashboard/common/Toolbar/CalendarViewMode.ts (1 hunks)
- tests/playwright/pages/Dashboard/common/Toolbar/index.ts (5 hunks)
- tests/playwright/tests/db/general/toolbarOperations.spec.ts (1 hunks)
- tests/playwright/tests/db/views/viewCalendar.spec.ts (8 hunks)
Files skipped from review as they are similar to previous changes (47)
- packages/nc-gui/assets/style.scss
- packages/nc-gui/components/cmd-k/index.vue
- packages/nc-gui/components/cmd-l/index.vue
- packages/nc-gui/components/dashboard/TreeView/CreateViewBtn.vue
- packages/nc-gui/components/dashboard/TreeView/ViewsNode.vue
- packages/nc-gui/components/dlg/ViewCreate.vue
- packages/nc-gui/components/dlg/ViewDelete.vue
- packages/nc-gui/components/nc/DateWeekSelector.vue
- packages/nc-gui/components/nc/Divider.vue
- packages/nc-gui/components/nc/Modal.vue
- packages/nc-gui/components/nc/MonthYearSelector.vue
- packages/nc-gui/components/nc/Select.vue
- packages/nc-gui/components/smartsheet/Toolbar.vue
- packages/nc-gui/components/smartsheet/calendar/DayView/DateField.vue
- packages/nc-gui/components/smartsheet/calendar/DayView/DateTimeField.vue
- packages/nc-gui/components/smartsheet/calendar/MonthView.vue
- packages/nc-gui/components/smartsheet/calendar/SideMenu.vue
- packages/nc-gui/components/smartsheet/calendar/WeekView/DateField.vue
- packages/nc-gui/components/smartsheet/calendar/WeekView/DateTimeField.vue
- packages/nc-gui/components/smartsheet/calendar/YearView.vue
- packages/nc-gui/components/smartsheet/toolbar/Calendar/ActiveView.vue
- packages/nc-gui/components/smartsheet/toolbar/Calendar/Header.vue
- packages/nc-gui/components/smartsheet/toolbar/Calendar/Mode.vue
- packages/nc-gui/components/smartsheet/toolbar/Calendar/Range.vue
- packages/nc-gui/components/smartsheet/toolbar/Calendar/Today.vue
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue
- packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue
- packages/nc-gui/components/smartsheet/toolbar/GroupByMenu.vue
- packages/nc-gui/components/smartsheet/toolbar/RowHeight.vue
- packages/nc-gui/components/smartsheet/toolbar/SearchData.vue
- packages/nc-gui/components/smartsheet/toolbar/SortListMenu.vue
- packages/nc-gui/components/smartsheet/toolbar/StackedBy.vue
- packages/nc-gui/components/smartsheet/topbar/SelectMode.vue
- packages/nc-gui/components/tabs/Smartsheet.vue
- packages/nc-gui/composables/useCalendarViewStore.ts
- packages/nc-gui/composables/useViewColumns.ts
- packages/nc-gui/utils/iconUtils.ts
- packages/nc-gui/windi.config.ts
- tests/playwright/pages/Dashboard/Calendar/CalendarSideMenu.ts
- tests/playwright/pages/Dashboard/Calendar/CalendarWeekDateTime.ts
- tests/playwright/pages/Dashboard/Calendar/CalendarYear.ts
- tests/playwright/pages/Dashboard/Calendar/index.ts
- tests/playwright/pages/Dashboard/ViewSidebar/index.ts
- tests/playwright/pages/Dashboard/common/Toolbar/CalendarViewMode.ts
- tests/playwright/pages/Dashboard/common/Toolbar/index.ts
- tests/playwright/tests/db/general/toolbarOperations.spec.ts
- tests/playwright/tests/db/views/viewCalendar.spec.ts
Change Summary
Provide summary of changes with issue number if any.
Update the calendar style.
Removed the Calendar topbar and moved them to toolbar and side menu
Updated posthog events
Updated tests to new ui
Change type
Test/ Verification
Provide summary of changes.
Additional information / screenshots (optional)
Anything for maintainers to be made aware of