-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent system fields from getting deleted manually #8285
base: develop
Are you sure you want to change the base?
fix: prevent system fields from getting deleted manually #8285
Conversation
WalkthroughWalkthroughThe update in the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sreehari2003 instead of removing delete option, it would be preferred to have it still in the menu - but keep it disabled. On hover- we can show tooltip Deleting system field is not allowed
@dstala I have added the tooltip. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
packages/nc-gui/lang/en.json
is excluded by!**/*.json
Files selected for processing (1)
- packages/nc-gui/components/smartsheet/header/Menu.vue (1 hunks)
Additional comments not posted (1)
packages/nc-gui/components/smartsheet/header/Menu.vue (1)
471-480
: Ensure deletion prevention logic is robust and clear.The implementation of the deletion prevention logic using
isDeleteAllowed
and checking if the column is a primary key (column?.pk
) is a good approach. It effectively prevents the deletion of system fields, aligning with the PR's objectives. The tooltip providing feedback when deletion is not allowed enhances user experience by making the restrictions clear.
e7417f4
to
be77f75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/nc-gui/components/smartsheet/header/Menu.vue (1 hunks)
Additional comments not posted (1)
packages/nc-gui/components/smartsheet/header/Menu.vue (1)
531-540
: Ensure tooltip and delete option behavior aligns with requirements.The tooltip correctly displays a message when the delete action is not allowed, and the delete option is disabled for primary keys (
column?.pk
) and when deletion is not allowed (!isDeleteAllowed
). This aligns with the PR objectives to prevent deletion of system fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/nc-gui/components/smartsheet/header/Menu.vue (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/nc-gui/components/smartsheet/header/Menu.vue
Change Summary
Provide summary of changes with issue number if any.
Change type
Test/ Verification
Provide summary of changes.
Additional information / screenshots (optional)
Anything for maintainers to be made aware of
Summary by CodeRabbit