Fix support for ncat --vsock -l <port>
#2807
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefano-garzarella
force-pushed
the
fix-vsock-listening
branch
from
b3a044b
to
cd4e578
Compare
Commit 04c4c70 ("Support decimal integer representation of target addresses. Fixes nmap#375") introduced a regression when the user specifies only the port using AF_VSOCK in listening (e.g. `ncat --vsock -l 1234`). Before that commit, we supported this invocation, but currently we interpret the parameter as CID. Alternatively, the version with -p is still working (e.g. `ncat --vsock -l -p 1234`). Having documented this usage in the manpage as well, it's better to fix it and support it again. Tested locally (without VMs involved), using CID = 1 (loopback) in this way: shell1$ ncat --vsock -l 1234 shell2$ ncat --vsock 1 1234 # Note: If CID 1 is not supported and the previous command fails, # it means that you have to manually load `vsock_loopback` kernel # module (usually it is autoamtically loaded when AF_VSOCK is used # if the `vsock` kernel module is not already loaded in the system) Reported-by: Luigi Leonardi <[email protected]> Signed-off-by: Stefano Garzarella <[email protected]>
stefano-garzarella
force-pushed
the
fix-vsock-listening
branch
from
cd4e578
to
6cd7b7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 04c4c70 ("Support decimal integer representation of target addresses. Fixes #375") introduced a regression when the user specify only the port using AF_VSOCK in listening (e.g.
ncat --vsock -l 1234).Before that commit we supported this invocation, but currently we interpret the parameter as CID. Alternatively, the version with -p is still working (e.g.
ncat --vsock -l -p 1234).Having documented this usage in the manpage as well, it's better to fix it and support it again.
Tested locally (without VMs involved), using CID = 1 (loopback) in this way:
Reported-by: Luigi Leonardi [email protected]