Increase service probes max line length #2803
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase the max line length in nmap-service-probes, add a more clear error when that limit is hit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the max line length in nmap-service-probes, add a more clear error when that limit is hit.
When adding a custom probe, we hit the max line length, but got a different error:
This was confusing as we did format it correctly. This change increases the max line length allowed, and adds a specific error for the case where a line is longer than the allowed buffer.
edit: Note, this was not an issue for UDP open port detection in 7.93 as the nmap-payloads file did not have such a limitation, but having a custom probe added previously is currently not possible in 7.94 due to this.