Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add upload_logs command #309

Merged
merged 3 commits into from
Mar 15, 2024
Merged

add upload_logs command #309

merged 3 commits into from
Mar 15, 2024

Conversation

nlef
Copy link
Owner

@nlef nlef commented Mar 8, 2024

Added bot command /upload_logs
the command is added automatically to the text of error messages for easy loading of logs
@CODeRUS @feadot pls test this)

@nlef nlef added Feature Request New feature or request Next release Extra attention is needed labels Mar 8, 2024
@nlef nlef added this to Long-Term suggestions in main development via automation Mar 8, 2024
@nlef nlef linked an issue Mar 8, 2024 that may be closed by this pull request
bot/main.py Outdated
"ip --details --statistics link show dev can0",
]
for command in commands:
subprocess.run(f"{command} >> {configWrap.bot_config.log_path}/debug.txt", shell=True, executable="/bin/bash", check=False)
Copy link

@CODeRUS CODeRUS Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add command itself and empty newline after:

command
command output
empty newline

@CODeRUS
Copy link

CODeRUS commented Mar 8, 2024

also as it not using sudo, might need checking result of dmesg grab. if no permissions, need to ask user to unrestrict dmesg calls by:

Creating a file /etc/sysctl.d/51-dmesg-restrict.conf with content:

kernel.dmesg_restrict = 0

and reboot. Or issue sudo sysctl kernel.dmesg_restrict=0

@nlef nlef requested a review from CODeRUS March 15, 2024 19:28
@CODeRUS
Copy link

CODeRUS commented Mar 15, 2024

любо

@nlef nlef merged commit ef83981 into development Mar 15, 2024
4 checks passed
@nlef nlef deleted the logs-uploading branch March 15, 2024 20:01
@feadot
Copy link

feadot commented Mar 15, 2024

Вообще мужчины!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request Next release Extra attention is needed
Projects
main development
Long-Term suggestions
Development

Successfully merging this pull request may close these issues.

Публикация лога
3 participants