Skip to content
This repository has been archived by the owner on Oct 7, 2022. It is now read-only.

Adjust lib and pythonPackages to upstream nixpkgs changes #471

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

hlolli
Copy link

@hlolli hlolli commented Feb 12, 2021

Importing python-packages from top-level is now curried 1 more level, to which I'm failing to understand and reproducing in nix repl, https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/interpreters/python/default.nix#L26

Accessing lib from pkgs.stdenv is now throwing warning so I'm changing the template too.

inherit (pkgs) stdenv;
python = pkgs.{{ python_version }};
};
pythonPackages = pkgs.python3.pkgs;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python3 must be {{ python_version }}

@hlolli
Copy link
Author

hlolli commented Feb 12, 2021

There are still two tests failing:

  1. https://bitbucket.org/tarek/flake8 doesn't exist anymore

  2. pypi2nix.requirements.IncompatibleRequirements: Cannot combine requirements with different urls <bound method UrlRequirement.url of UrlRequirement(_name='req', _url='https://url.test', _extras=set(), _environment_markers=None, _logger=<pypi2nix.logger.StreamLogger object at 0x7f0a6ea8feb0>)> and <bound method UrlRequirement.url of UrlRequirement(_name='req', _url='https://url.test', _extras=set(), _environment_markers=None, _logger=<pypi2nix.logger.StreamLogger object at 0x7f0a6ea8feb0>)>

https://url.test seems to my eyes to be equal to https://url.test will look into this one...

@seppeljordan
Copy link
Contributor

You will need to fork this repo since the tests fail and I cannot merge the tests unless they are green. sorry

@hlolli
Copy link
Author

hlolli commented Feb 13, 2021

You will need to fork this repo since the tests fail and I cannot merge the tests unless they are green. sorry

That's what I meant, I'm looking into these test failure. Will update once done.

@srghma
Copy link

srghma commented Feb 15, 2022

still significant

have this error on installing

{ pkgs ? import <nixpkgs-master> {} }:

let
pypi2nix = import (pkgs.fetchgit {
  url = "https://github.com/nix-community/pypi2nix";
  # adjust rev and sha256 to desired version
  rev = "v2.0.4";
  sha256 = "sha256:0mxh3x8bck3axdfi9vh9mz1m3zvmzqkcgy6gxp8f9hhs6qg5146y";
}) { inherit pkgs; };
in

pkgs.mkShell {
  buildInputs = with pkgs; [
    pypi2nix
  ];
}
error: attribute 'lib' missing, at /nix/store/syg1rgl1l8baj5xh59xw3xqi0s9bh3fd-pypi2nix/requirements.nix:15:12
(use '--show-trace' to show detailed location information)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants