Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace nixpkgs-fmt with nixfmt-rfc-style #511

Merged
merged 4 commits into from
Aug 15, 2024
Merged

replace nixpkgs-fmt with nixfmt-rfc-style #511

merged 4 commits into from
Aug 15, 2024

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 15, 2024

No description provided.

github-actions bot and others added 3 commits July 15, 2024 01:34
Flake lock file updates:

• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/ab82a9612aa45284d4adf69ee81871a389669a9e?narHash=sha256-5r0pInVo5d6Enti0YwUSQK4TebITypB42bWy5su3MrQ%3D' (2024-07-07)
  → 'github:NixOS/nixpkgs/aa247c0c90ecf4ae7a032c54fdc21b91ca274062?narHash=sha256-GaliJqfFwyYxReFywxAa8orCO%2BEnDq2NK2F%2B5aSc8vo%3D' (2024-07-14)
• Updated input 'treefmt-nix':
    'github:numtide/treefmt-nix/e1d7bd5ec6fc389eb3a90e232c4150338bf6a508?narHash=sha256-ludjqxhR/5lXwJ1H6zHmZqp%2B4e8dFPHE9FIZ2eBh2G4%3D' (2024-07-07)
  → 'github:numtide/treefmt-nix/b92afa1501ac73f1d745526adc4f89b527595f14?narHash=sha256-VZK73b5hG5bSeAn97TTcnPjXUXtV7j/AtS4KN8ggCS0%3D' (2024-07-14)
@bbenne10
Copy link
Contributor

LGTM. Not sure of the necessity to change to nixfmt-rfc-style, but I don't have strong feelings one way or the other - so long as the style is automated and enforced.

@Mic92
Copy link
Member Author

Mic92 commented Aug 15, 2024

LGTM. Not sure of the necessity to change to nixfmt-rfc-style, but I don't have strong feelings one way or the other - so long as the style is automated and enforced.

nixpkgs-fmt is deprecated and it's nice to have a standard that is used everywhere, because it makes things simpler.

@Mic92 Mic92 merged commit cff4f3c into master Aug 15, 2024
32 of 34 checks passed
@Mic92 Mic92 deleted the joerg-ci branch August 15, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants