Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding the dist server #124

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

roblabla
Copy link

@roblabla roblabla commented Nov 21, 2023

The goal of this PR is to make it possible to use a mirror of rustup, such as one created using Panamax, with fenix.

To do so, it fixes three issues:

  • When setting a custom dist server, if the manifest contains links to the default dist server, rustup will automatically replace it with an URL pointing to the custom dist server. This allows making very naive mirrors of the rustup dist server without having to modify the channel manifests.
    Currently, fenix allows setting a custom dist server through toolchainOf, but it does not replicate this behavior of overriding the URL in the manifests. This PR adds this behavior.

  • Furthermore, it adds a root argument to fromToolchainFile, allowing the simultaneous use of a toolchain file and a custom dist server.

  • Finally, it replaces the archive it gets from the gz ones to xz ones. Rust started providing xz archives in may 2017, and rustup switched to grabbing the xz archives not long after. Panamax, the most popular tool to mirror rustup, defaults to only grabbing the xz archives.

@roblabla
Copy link
Author

roblabla commented Feb 8, 2024

Bump?

@roblabla
Copy link
Author

Bump? Is this project dead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant