Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdm: Adds basic lock file invalidation #1035

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

purepani
Copy link
Contributor

@purepani purepani commented Aug 9, 2024

Basic idea for lock invalidation in pdm.
This would fix #999 but isn't exactly complete.
All this does is pull the hash from the lock file, and manually calculate the hash in the same way that pdm does. This isn't a great solution because any time pdm changes the way the lock file hash is calculated.
The alternatives are:

  • Use runCommand on a script that makes pdm evaluate whether the lock file is valid or not. This seems a bit clunky to me.
  • Use an external lock file to store lock file hashes. I think this is a better way to do it, but at least the way I'm imagining it, might require some work. In my head, the best solution would be a single dream.lock file, that would contain data for all hashes for all lock files for any given project; i.e., instead of the way that the pip and npm work, where they generate a full lock file on their own, we can generate the lock files for any given tool and store the invalidation hash instead.

I'd like to suggest the second solution since it could allow for easier usage of many package managers for a variety of language, but it's also a little involved.
@DavHau @phaer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdm: groups at the top of pdm.lock don't update once lockfile exists
1 participant