Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update exports #292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update exports #292

wants to merge 1 commit into from

Conversation

oseh-stake
Copy link

In NextJS12, the present configuration produces an error.

This can be rectified by using module.exports = require('./dist/MUIRichTextEditor')

@oseh-stake
Update exports
4bfbe9f 
In NextJS12, the present configuration produces an error. 

This can be rectified by using module.exports = require('./dist/MUIRichTextEditor')
@oseh-stake oseh-stake mentioned this pull request Dec 24, 2021
Open
3 tasks
@paradoxkb
Copy link

@oseh-stake sure, I used this way in my case for use the module. But import from dist isn't normal way and you are agree with it I think.

@chrishj59 chrishj59 mentioned this pull request Dec 25, 2021
Closed
1 task
@oseh-stake
Copy link
Author

@paradoxkb I have seen it before in other packages

corneliugaina
corneliugaina approved these changes Mar 29, 2022
View reviewed changes
Copy link

@corneliugaina corneliugaina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok let's go

@Joris-Hotton
Copy link

Please do this PR in order to unlock people (like me !!)

Joris-Hotton
Joris-Hotton approved these changes Jul 7, 2022
View reviewed changes
Copy link

@Joris-Hotton Joris-Hotton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbowler benbowler benbowler approved these changes

@Angrigo Angrigo Angrigo approved these changes

@WilliamZimmermann WilliamZimmermann WilliamZimmermann approved these changes

@corneliugaina corneliugaina corneliugaina approved these changes

@Joris-Hotton Joris-Hotton Joris-Hotton approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@oseh-stake @paradoxkb @Joris-Hotton @benbowler @Angrigo @WilliamZimmermann @corneliugaina