Fix memory leak of Rules, use bool phony_ member to identify phony edges #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhasse
force-pushed
the
dont-leak-rules
branch
from
92d2fd5
to
55bafb3
Compare
| } | ||
|
|
||
| bool Rule::IsPhony() const { | ||
| return phony_; |
There was a problem hiding this comment.
nit: Can we just store the address of this Rule in State::phony_rule_ and implement State::IsPhony(const Rule* rule) { return rule == phony_rule_; } instead? This would avoid adding 8 bytes to each Rule instance due to padding.
|
Apart from my nit, this LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is worth it and what the performance impact is.