[Backport 1.6] + added nimsuggest support for exception inlay hints (#23202) #23421
Conversation
This adds nimsuggest support for displaying inlay hints for exceptions. An inlay hint is displayed around function calls, that can raise an exception, which isn't handled in the current subroutine (in other words, exceptions that can propagate back to the caller). On mouse hover on top of the hint, a list of exceptions that could propagate is shown. The changes, required to support this are already commited to nimlangserver and the VS code extension. The extension and the server allow configuration for whether these new exception hints are enabled (they can be enabled or disabled independently from the type hints), as well as the inlay strings that are inserted before and after the name of the function, around the function call. Potentially, one of these strings can be empty, for example, the user can choose to add an inlay hint only before the name of the function, or only after the name of the function. (cherry picked from commit 899ba01)
|
Isn't this getting out of hand? Backporting massive new features like this has nothing to do with "semver". Ping @arnetheduck |
depends on how you look at it - the root of the problem here is the distribution model of nimsuggest (and its implementation as a when jungle on top of the compiler) which ties its release cycle to nim itself even though the change has nothing to do with the functionality added in newer nim versions - ie computing exception effects is not a new feature in nim - this PR is merely exposing a language feature that has existed for a long time. We've not been able to migrate to 2.0 yet because tests still reveal significant problems so 1.6 continues to be the most viable target for production development - backporting here is a way to bring useful tooling improvements to a larger developer base without tying it to the nim bugfix schedule. |
|
Have you not run into this? It makes the feature borderline useless right now. Not something to spread everywhere. |
This adds nimsuggest support for displaying inlay hints for exceptions. An inlay hint is displayed around function calls, that can raise an exception, which isn't handled in the current subroutine (in other words, exceptions that can propagate back to the caller). On mouse hover on top of the hint, a list of exceptions that could propagate is shown.
The changes, required to support this are already commited to nimlangserver and the VS code extension. The extension and the server allow configuration for whether these new exception hints are enabled (they can be enabled or disabled independently from the type hints), as well as the inlay strings that are inserted before and after the name of the function, around the function call. Potentially, one of these strings can be empty, for example, the user can choose to add an inlay hint only before the name of the function, or only after the name of the function.
(cherry picked from commit 899ba01)