Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake: minor changes #69

Merged
merged 1 commit into from
Feb 18, 2024
Merged

flake: minor changes #69

merged 1 commit into from
Feb 18, 2024

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Feb 10, 2024

This PR:

  • Update flake.lock to remove the warning
    image
  • Make a minor refactor of flake.nix

Copy link
Owner

@nikstur nikstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things but looks good otherwise. Thank you!

flake.nix Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
@drupol drupol marked this pull request as ready for review February 17, 2024 09:28
Copy link
Owner

@nikstur nikstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited my few nits myself. Thanks!

@nikstur nikstur merged commit 5d9ee4e into nikstur:main Feb 18, 2024
1 check passed
@drupol
Copy link
Contributor Author

drupol commented Feb 19, 2024

Why is flake-utils needed?

@nikstur
Copy link
Owner

nikstur commented Feb 20, 2024

Why is flake-utils needed?

So that we only have one version both in rust-overlay and in pre-commit-hooks-nix

@drupol
Copy link
Contributor Author

drupol commented Feb 20, 2024

TIL, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants