Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support width: 'auto' and improve hash support #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jameswilson
Copy link

I've made a few improvements for a project here and wanted to offer to push these back up stream.

The changes include:

  • Use @preserve in the docblock so that the file can be minified with Google closure-compile without stripping the license, info and copyright.
  • Change whitespace to be more consistent. Tabs and spaces are being used inconsistently and there were a few cases of trailing slashes. I've converted everything to tabs.
  • Support a default setting of width: 'auto', to fill the container element.
  • Allow reading the hash from the URL on first load, to open the correct tab, and change the default setting to hideHash: false, to take advantage of this feature by default.

1) Check URL fragment on first load, by default.

2) Fix HTML validation errors in example code.

* attribute 'name' not allowed on element div.
* attribute 'id'  must start with [a-zA-Z].

3) to prevent browsers from scrolling around the page when clicking tabs, remove the leading '#' in href attribute and add a trailing underscore '_' to id attribute on div.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant