Increase default timeout for browserstack env.
#4349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Status
|
|
Can you explain what your PR does? |
Default client timeout was less (15000ms) in nightwatch leading client disconnect for turboscale and showing error on dashboard, to fix it increased the timeout. |
|
According to the CONTRIBUTING.md, you should be submitting an issue first |
garg3133
changed the title
browserstack env.
|
@BeginArjun That's okay, this is a small fix. @Rohannagariya1 Can you please update the failing tests as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default timeout while initiating a session with BrowserStack is not long enough when testing on mobile devices or Turboscale leading to frequent connection reset errors. This PR increases the timeout to handle such cases.