Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: type declaration file, update dependencies #2

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add: type declaration file, update dependencies #2

wants to merge 5 commits into from

Conversation

vaibhavsingh97
Copy link
Member

@vaibhavsingh97 vaibhavsingh97 commented Mar 22, 2023 •
edited
Loading

Updated Dependencies ✨

Packages Before After
@vitejs/plugin-react ^3.0.1 ^3.1.0
chromedriver ^108.0.0 ^111.0.0
eslint ^8.26.0 ^8.36.0
get-port ^5.1.1 ^6.1.2
jsdom ^20.0.2 ^21.1.1
nightwatch ^2.6.10 ^2.6.18
rimraf ^3.0.2 ^4.4.0
vite ^4.0.4 ^4.2.1

Added Typescript Types

@vaibhavsingh97 vaibhavsingh97 marked this pull request as draft March 22, 2023 15:13
@vaibhavsingh97 vaibhavsingh97 marked this pull request as ready for review March 23, 2023 08:14
beatfactor
beatfactor reviewed Mar 23, 2023
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
swrdfish
swrdfish suggested changes Apr 4, 2023
View reviewed changes
test/src/formTest.js
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated change.

vaibhavsingh97
vaibhavsingh97 commented May 9, 2023
View reviewed changes
package.json
@@ -21,26 +21,28 @@
],
"homepage": "https://nightwatchjs.org",
"license": "MIT",
"types": "index.d.ts",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add index.d.ts in files section as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatfactor beatfactor beatfactor left review comments

@swrdfish swrdfish swrdfish requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaibhavsingh97 @beatfactor @swrdfish