Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom commands doc display on GitHub #85

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix custom commands doc display on GitHub #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion guide/extending-nightwatch/custom-commands.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,8 @@ module.exports = Pause;</code></pre>
</div>

<br>

##### The "complete" event
Signaling the `complete` event needs to be done inside an asynchronous action (e.g. a `setTimeout` call). Command classes that do not extend `EventEmitter` will be treated similar to command functions, requiring that the `command` method calls at least one Nightwatch api method to be able to complete.

<p class="alert alert-warning">Using ES6 classes as custom commands is not supported at the moment. See [nightwatchjs#1199](https://github.com/nightwatchjs/nightwatch/issues/1199) for more details.</p>
<p class="alert alert-warning">Using ES6 classes as custom commands is not supported at the moment. See <a href="https://github.com/nightwatchjs/nightwatch/issues/1199">nightwatchjs#1199</a> for more details.</p>