-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically rendering PageNavigators. #297
base: versions/3.0
Are you sure you want to change the base?
Dynamically rendering PageNavigators. #297
Conversation
70c4195
to
322611f
Compare
This is cool. Thanks a lot, will review it soon. |
fa0ab37
to
2406d5f
Compare
Requested changes are pushed. Please review it when you had time. |
bc056d4
to
85ef304
Compare
@beatfactor Should I update .gitignore then? |
it's fine, you can leave it. |
@nothuman2718 Try not to force push on the PR every time you make some changes, it makes it hard to assess the improvements you've made after the last review. |
Sure. Noted!! |
For a few pages, the titles that we have in the page navigators are different from the titles we have on the sidebar (on the main website) while they're going to match exactly with this PR. I think it might be a good idea to keep these titles for page navigators and not match all the page navigator titles with the titles on the sidebar. This would be especially useful when we have situations like below where the "Next Page" such says "Introduction" while it should be something like "Introduction to Mobile Testing". This could be easily achieved by supplying an alternative title for each page (if applicable) in the @beatfactor What do you think? |
Yes, we should have an alternative link title in the navItems list. |
Sure. |
@garg3133 Please have a look. |
Dynamically rendering PageNavigators.
With this change, the Next Prev page navigators will be generated dynamically.
Review time on a scale of 1-5 is 3.