Skip to content

Commit

Permalink
microG Installer Revived 4.1.0-0
Browse files Browse the repository at this point in the history
  • Loading branch information
@nift4
nift4 committed Sep 8, 2024
1 parent d733264 commit 2751a67
Show file tree
Hide file tree
Showing 7 changed files with 23 additions and 18 deletions.
11 changes: 9 additions & 2 deletions CHANGELOG
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,9 @@
rework install process (see README for details)
but upgrading should not require manual intervention
Improve compatibility with stock ROMs.

To install this module on a stock ROM:

This comment has been minimized.

Sign in to view

Copy link
@bphd

bphd Sep 18, 2024

@nift4 Only stock ROM or any ROM that comes with Google things? Or even if the user installed theses himself at some moment?

This comment has been minimized.

Sign in to view

Copy link
@nift4

nift4 Sep 18, 2024

Author Owner

if it's a third party rom, just use a third party rom without gapps instead

This comment has been minimized.

Sign in to view

Copy link
@bphd

bphd Sep 18, 2024

if it's a third party rom, just use a third party rom without gapps instead

@nift4 yeah but we're not in the user head, he don't know how Google shenanigans works all the time. Need to cover all cases. Basically if you really meant "any case where original Google things are installed", state it directly, the user will figure out

This comment has been minimized.

Sign in to view

Copy link
@nift4

nift4 Sep 18, 2024

Author Owner

if stock ROM with google -> follow these instructions
if third party ROM with google -> use another third party ROM without Google

This comment has been minimized.

Sign in to view

Copy link
@bphd

bphd Sep 18, 2024

if stock ROM with google -> follow these instructions if third party ROM with google -> use another third party ROM without Google

@nift4 I guess those instructions works aswell for CROM with GApps, but anyway at least write what each case should do, the naked CROM, GApps CROM and ROM

This comment has been minimized.

Sign in to view

Copy link
@nift4

nift4 Sep 19, 2024

Author Owner

I don't think its a good idea to use custom ROM with gapps with this module but whatever

This comment has been minimized.

Sign in to view

Copy link
@bphd

bphd Sep 19, 2024

@nift4 Mention it, even if it's only a thought, so people know they should change. But I still think that the case of CROM+GApps seems similar to ROM here and should be merged
1. Install gms_delete.zip from https://github.com/user-attachments/files/16912362/gms_delete.zip

This comment has been minimized.

Sign in to view

Copy link
@bphd

bphd Sep 18, 2024 •
edited
Loading

@nift4 it's said to not support KSU yet you advise it here considering that most user will use it on KSU

At least provide manual instructions/commands for user on KSU

After installation of it, there is a module that you can activate/deactivate. It's supposed to be uninstalled, deactivated, let activated, something?

This comment has been minimized.

Sign in to view

Copy link
@nift4

nift4 Sep 18, 2024

Author Owner

Literally the first sentence of microg_installer_revived README is "This is a Magisk module".

After installation of it, there is a module that you can activate/deactivate. It's supposed to be uninstalled, deactivated, let activated, something?

I don't say anything so you don't do anything - just let it stay enabled

This comment has been minimized.

Sign in to view

Copy link
@bphd

bphd Sep 18, 2024

@nift4 it's important to write it on the module name or in here of something more big because that cause soft brick

So it doesn't change anything activated deactivated uninstalled, interesting

This comment has been minimized.

Sign in to view

Copy link
@nift4

nift4 Sep 19, 2024

Author Owner

it's important to write it on the module name or in here of something more big because that cause soft brick

It's the first sentence??? If people don't read and they soft-brick their phone, maybe consider reading :D

So it doesn't change anything activated deactivated uninstalled, interesting

What? Because there are no further instructions, it is supposed to be enabled. It'll break when deleted

This comment has been minimized.

Sign in to view

Copy link
@bphd

bphd Sep 19, 2024

@nift4 first sentence say to install it without any kind of warning like it's harmless; we're commenting it right now

It'll break when deleted, so it doesn't remove what it removes, only overlay them through systemless, so when module removed, the old files aren't unmounted causing a problem. So that module is for permanently unmount original Google things, the name of the module is misleading, should be maybe gms_overlay or gms_unmount, or idk. Because if it was really deleting, then its presence would be meh, because already have deleted what it needs to
2. Reboot
3. Uninstall Google Play Services using Settings or `pm uninstall`

This comment has been minimized.

Sign in to view

Copy link
@bphd

bphd Sep 18, 2024 •
edited
Loading

@nift4 What is GPS? com.google.android.gms?

This comment has been minimized.

Sign in to view

Copy link
@nift4

nift4 Sep 18, 2024

Author Owner

Yes

This comment has been minimized.

Sign in to view

Copy link
@bphd

bphd Sep 18, 2024

Yes

@nift4 amend for clarity

This comment has been minimized.

Sign in to view

Copy link
@nift4

nift4 Sep 18, 2024

Author Owner

"Google Play Services" is the name shown in Settings. It's also a general term for com.google.android.gms + com.google.android.gsf + com.android.vending which should be uninstalled after all

This comment has been minimized.

Sign in to view

Copy link
@bphd

bphd Sep 18, 2024 •
edited
Loading

"Google Play Services" is the name shown in Settings. It's also a general term for com.google.android.gms + com.google.android.gsf + com.android.vending which should be uninstalled after all

Mines named otherwise. Amend for clarity. Clearer the better. State directly "com.google.android.gms + com.google.android.gsf + com.android.vending", those instructions are meant for new users, they ain't no Google guru

This comment has been minimized.

Sign in to view

Copy link
@nift4

nift4 Sep 18, 2024

Author Owner

Done
4. Install microG APK (must succeed) and Companion / Play Store APK

This comment has been minimized.

Sign in to view

Copy link
@bphd

bphd Sep 18, 2024

@nift4 Any MG APK available on internet? Or one provided by you somewhere?

Play store APK is com.android.vending? Any version advised or not advised?

What is companion? com.google.android.ims?

This comment has been minimized.

Sign in to view

Copy link
@nift4

nift4 Sep 18, 2024

Author Owner

Companion is a Play Store replacement.

Companion: https://github.com/microg/GmsCore/releases/download/v0.3.2.240913/com.google.android.gms-240913004.apk

for real Play Store use apkmirror

This comment has been minimized.

Sign in to view

Copy link
@bphd

bphd Sep 18, 2024 •
edited
Loading

Companion is a Play Store replacement.

Companion: https://github.com/microg/GmsCore/releases/download/v0.3.2.240913/com.google.android.gms-240913004.apk

for real Play Store use apkmirror

@nift4 It's fake store?

This comment has been minimized.

Sign in to view

Copy link
@nift4

nift4 Sep 18, 2024

Author Owner

it used to be called fake store, but microg project renamed it

This comment has been minimized.

Sign in to view

Copy link
@bphd

bphd Sep 18, 2024

it used to be called fake store, but microg project renamed it

@nift4 You haven't replied to everything 2751a67#r146868167

This comment has been minimized.

Sign in to view

Copy link
@bphd

bphd Sep 18, 2024 •
edited
Loading

microG: https://github.com/microg/GmsCore/releases/download/v0.3.2.240913/com.google.android.gms-240913004.apk

Companion: https://github.com/microg/GmsCore/releases/download/v0.3.2.240913/com.android.vending-84022604.apk

@nift4 Okay so only that version of MicroG from that particular place, you should put it there aswell

And version for vending (official APK mirror one)?

This comment has been minimized.

Sign in to view

Copy link
@nift4

nift4 Sep 18, 2024

Author Owner

it's just the newest version from the official download page, no magic. vending version doesn't matter

This comment has been minimized.

Sign in to view

Copy link
@bphd

bphd Sep 18, 2024 •
edited
Loading

Okay interesting to know. Where things don't works we doubt of everything as not many things are explained. Just sad that it's not public knowledge, even if it's dumb, that simplify the troubleshoot a little. If it was me I would have stated each time, for letting as less doubt as possible

This comment has been minimized.

Sign in to view

Copy link
@nift4

nift4 Sep 19, 2024 •
edited
Loading

Author Owner

The links I sent can also be found with first google result for "microg download" ¯\_(ツ)_/¯

This comment has been minimized.

Sign in to view

Copy link
@bphd

bphd Sep 19, 2024

Not really the part about where to find what. But most particularly the part about, the module author, you, permit what version of what for compatibility with its module
5. Install microG Installer Revived

This comment has been minimized.

Sign in to view

Copy link
@bphd

bphd Sep 18, 2024

@nift4 What if already installed? Reinstallation needed? Useless step? Need to uninstall and restart all instructions? Something else?

This comment has been minimized.

Sign in to view

Copy link
@nift4

nift4 Sep 18, 2024

Author Owner

these instructions are for a fresh install

This comment has been minimized.

Sign in to view

Copy link
@bphd

bphd Sep 18, 2024

these instructions are for a fresh install

@nift4 yeah but one more time, not in user head. Maybe he has installed the module, then tried those instructions because he did it wrong way. So he is fine or he need a reinstallation or a total uninstalling and restart?

This comment has been minimized.

Sign in to view

Copy link
@nift4

nift4 Sep 18, 2024

Author Owner

if he did it the wrong way he should start over. I don't test doing it wrong so idk what I am supposed to say

This comment has been minimized.

Sign in to view

Copy link
@bphd

bphd Sep 18, 2024 •
edited
Loading

if he did it the wrong way he should start over. I don't test doing it wrong so idk what I am supposed to say

@nift4 Well explaining the point of installing it last, so the consequences of not doing that, because that list seems to follow a precise order. If not then we can install it at any steps and restarting over don't make sense

This comment has been minimized.

Sign in to view

Copy link
@nift4

nift4 Sep 19, 2024

Author Owner

the consequences of not following the instructions will indeed most probably be an error

This comment has been minimized.

Sign in to view

Copy link
@bphd

bphd Sep 19, 2024

Okay so MGIR do need to be installed last. So you should ask as first step to uninstall if not done already, because it seems to be mandatory
6. Reboot
18 changes: 8 additions & 10 deletions customize.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,11 @@ if ! [[ -f "$VD_PATH" ]]; then
fi
# Do install tasks
ui_print "- Installing microG GmsCore"
if [ -d "/product/priv-app/GmsCore" ]; then
mkdir -p "$MODPATH/product/priv-app/GmsCore"
cp "$GMS_PATH" "$MODPATH/product/priv-app/GmsCore/GmsCore.apk"
rm -f "$MODPATH/system/priv-app/GmsCore/GmsCore.apk"
if [ ! -d "/my_bigball/priv-app/GmsCore" ]; then
mkdir -p "$MODPATH/system/product/priv-app/GmsCore"
cp "$GMS_PATH" "$MODPATH/system/product/priv-app/GmsCore/GmsCore.apk"
else
rm -rf "$MODPATH/product/priv-app/GmsCore/"
mkdir -p "$MODPATH/system/priv-app/microG"
cp "$GMS_PATH" "$MODPATH/system/priv-app/microG/microG.apk"
fi
if (echo "$DUMP_VD" | grep "android.permission.FAKE_PACKAGE_SIGNATURE") >/dev/null; then
Expand All @@ -87,12 +86,11 @@ if (echo "$DUMP_VD" | grep "android.permission.FAKE_PACKAGE_SIGNATURE") >/dev/nu
else
ui_print "- Installing Play Store"
fi
if [ -d "/product/priv-app/Phonesky" ]; then
mkdir -p "$MODPATH/product/priv-app/Phonesky"
cp "$VD_PATH" "$MODPATH/product/priv-app/Phonesky/Phonesky.apk"
rm -f "$MODPATH/system/priv-app/Phonesky/Phonesky.apk"
if ! [ -d "/my_bigball/priv-app/GmsCore" ]; then
mkdir -p "$MODPATH/system/product/priv-app/Phonesky"
cp "$VD_PATH" "$MODPATH/system/product/priv-app/Phonesky/Phonesky.apk"
else
mkdir -p "$MODPATH/system/product/priv-app/Phonesky"
cp "$VD_PATH" "$MODPATH/system/priv-app/Phonesky/Phonesky.apk"
rm -rf "$MODPATH/product/priv-app/Phonesky/"
fi
mmm_exec hideLoading
4 changes: 2 additions & 2 deletions module.prop
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
id=microg_installer
name=microG Installer Revived
version=Revived 4.0.2-0
versionCode=40020
version=Revived 4.1.0-0
versionCode=40100
author=nift4
description=Install microG GmsCore, Companion (or Play Store if you want so), GsfProxy and MapsV1 to /system/
updateJson=https://raw.github.com/nift4/microg_installer_revived/master/update.json
Expand Down
Empty file removed system/priv-app/GmsCore/.replace
View file
Empty file.
Empty file removed system/priv-app/Phonesky/.gitkeep
View file
Empty file.
Empty file removed system/priv-app/microG/.gitkeep
View file
Empty file.
8 changes: 4 additions & 4 deletions update.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"version": "Revived 4.0.2-0",
"versionCode": 40020,
"zipUrl": "https://github.com/nift4/microg_installer_revived/releases/download/v4.0.2-0/microG_Installer_Revived.zip",
"changelog": "https://github.com/nift4/microg_installer_revived/raw/v4.0.2-0/CHANGELOG"
"version": "Revived 4.1.0-0",
"versionCode": 40100,
"zipUrl": "https://github.com/nift4/microg_installer_revived/releases/download/v4.1.0-0/microG_Installer_Revived.zip",
"changelog": "https://github.com/nift4/microg_installer_revived/raw/v4.1.0-0/CHANGELOG"
}

1 comment on commit 2751a67

@bphd
Copy link

@bphd bphd commented on 2751a67 Sep 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my_bigBall instead of product
nesting into system
deleting old version paths
PhoneSky instead of GMSCore

Please sign in to comment.