Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update page with new highlights instead of delete and reimport #394

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update page with new highlights instead of delete and reimport #394

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
475534b
add only new highlights to page
ofer1992 Jun 17, 2024
cbcbdfe
Merge branch 'nicdun:main' into main
ofer1992 Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 16 additions & 19 deletions src/utils/logseqPage.util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,39 +19,36 @@ export const generateLogseqPage = async (item: KindleBook): Promise<void> => {
return createOrLoadLogseqPage(item, prefix);
};

const getHighlightFromBlock = (
block: BlockEntity
): string => {
const lines = block.content.split('\n').slice(0, -Object.entries(block.properties!).length);
return lines.join('\n');
};

const createOrLoadLogseqPage = async (
item: KindleBook,
prefix: string,
): Promise<void> => {
const existingPage: LogseqPageEntity | null = await getPageByTitle(
item.title!,
);
const pageProperties = mapKindleDataToProperties(item);

const title = `${prefix ? prefix + "/" : ""}${item.title}`;

if (existingPage) {
sendNotification(
"Page already imported - Please delete page and reimport highlights!",
"error"
);
logseq.App.pushState("page", { name: title });
return;
} else {
await logseq.Editor.createPage(title);
logseq.App.pushState("page", { name: title });
}
await logseq.Editor.createPage(title);
logseq.App.pushState("page", { name: title });

const firstBlockOnPage: BlockEntity = (
await logseq.Editor.getCurrentPageBlocksTree()
)[0];
const currentPage = await logseq.Editor.getCurrentPage();
const blocksTree = await logseq.Editor.getPageBlocksTree(currentPage!.uuid);
const firstBlockOnPage: BlockEntity = blocksTree[0];

createPagePropertiesBlock(firstBlockOnPage, pageProperties);
updateBlockState(firstBlockOnPage);

const currentPage = await logseq.Editor.getCurrentPage();
// filter highlights to only new ones
const existingContents = new Set(blocksTree.slice(1).map(getHighlightFromBlock));
const newHighlights = item.highlights.filter(highlight => !existingContents.has(highlight.text));

for (const highlight of item.highlights) {
for (const highlight of newHighlights) {
await createBlockOnCurrentPage(currentPage!.uuid, highlight);
}

Expand Down