Skip to content

Commit

Permalink
Update Storybook to 7.6.13 (#1812)
Browse files Browse the repository at this point in the history
# Pull Request

## 🀨 Rationale

Wanted to see if there were any improvements.

## πŸ‘©β€πŸ’» Implementation

- Bumped version from 7.4.0 to 7.6.13
- Had to work around an
[issue](storybookjs/storybook#25170) related
to the typing of `withActions` decorator of actions add-on.
~~Re-exporting `withActions` from our Storybook utilities file with a
type that works (based on [comment in related
issue](storybookjs/storybook#22384 (comment)
Now providing type argument to generic `withActions` function.
- Marked docs support disabled in `addon-essentials` since we import
that addon separately (`addon-docs`) so we can configure it. Not sure if
this improves anything, but it doesn't seem to hurt.
- Also fixes #1639

## πŸ§ͺ Testing

Ran Storybook. `npm run storybook` seems to get everything ready about
25% faster (40s -> 30s).

## βœ… Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.
  • Loading branch information
m-akinc authored Feb 9, 2024
1 parent 9990a84 commit e68df6d
Show file tree
Hide file tree
Showing 30 changed files with 3,758 additions and 6,117 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Storybook to 7.6.13",
"packageName": "@ni/nimble-components",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Loading

0 comments on commit e68df6d

Please sign in to comment.