Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the NGXS Data Plugin's ReadMe Path #1962

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matthewalltop
Copy link

@matthewalltop matthewalltop commented Jan 9, 2023

docs(ReadMe): @ngxs-labs/data plugin links to deprecated ReadMe

Updated ReadMe Path to non-deprecated repository

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

ReadMe.md directs @ngxs-labs/data plugin ReadMe to deprecated repository

Issue Number: N/A

What is the new behavior?

Correct Repository is Linked

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codeclimate
Copy link

codeclimate bot commented Jan 9, 2023

Code Climate has analyzed commit 695056c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 97.0% (0.0% change).

View more on Code Climate.

Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the development of what used to be the @ngxs-labs/data plugin has moved to @angular-ru/ngxs.
I think that it may be better to make the note here that the @ngxs-labs/data has been deprecated and refer to the replacement plugin, listing this plugin in a separate line.
@splincode please confirm if this is what you would like to be done here?

@markwhitfeld
Copy link
Member

@splincode Any thoughts on this (see my comment☝️) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants