make blinded messages in melt optional #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution @elnosh. This is interesting, the nut states that outputs are required, but since this nut is optional it could lead to problems if the wallet does not support nut-8. Is this what you are testing? Requesting a melt with a wallet that does not suuport fee returns? |
yes, that was what I was testing. Melt requests from wallets that don't do nut-08 will fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the
PostMeltBolt11Requeststruct to have optionaloutputsinstead of required. Mint would throw an error if it received a melt request without theoutputsfield but it shouldn't since that field is optional from NUT-08