Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft(abc:price): add price component #1259

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jun 1, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@cipchk cipchk changed the title feat(abc:price): add price component draft(abc:price): add price component Jun 1, 2021
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #1259 (ad63d55) into master (7779c33) will increase coverage by 0.05%.
The diff coverage is 41.66%.

❗ Current head ad63d55 differs from pull request most recent head 9a81ab8. Consider uploading reports for the commit 9a81ab8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1259      +/-   ##
==========================================
+ Coverage   95.89%   95.95%   +0.05%     
==========================================
  Files         269      280      +11     
  Lines        8255     8497     +242     
  Branches     1498     1677     +179     
==========================================
+ Hits         7916     8153     +237     
- Misses        157      160       +3     
- Partials      182      184       +2     
Impacted Files Coverage Δ
packages/abc/price/price.component.ts 36.36% <36.36%> (ø)
packages/abc/price/price.module.ts 100.00% <100.00%> (ø)
packages/form/src/widgets/string/string.widget.ts 80.95% <0.00%> (-6.15%) ⬇️
packages/abc/xlsx/xlsx.service.ts 90.32% <0.00%> (-1.99%) ⬇️
packages/abc/tag-select/tag-select.component.ts 90.90% <0.00%> (-1.10%) ⬇️
packages/util/other/logger.ts 81.81% <0.00%> (-0.80%) ⬇️
packages/util/other/assert.ts 85.71% <0.00%> (-0.65%) ⬇️
...kages/form/src/widgets/cascader/cascader.widget.ts 84.61% <0.00%> (-0.57%) ⬇️
packages/util/format/string.ts 92.85% <0.00%> (-0.48%) ⬇️
packages/abc/exception/exception.component.ts 94.44% <0.00%> (-0.43%) ⬇️
... and 231 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7779c33...9a81ab8. Read the comment docs.

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Jun 1, 2021

Preview is ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants