-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ceph: Enable separate builds of ceph & rgw FSALs #16
base: centos-ci
Are you sure you want to change the base?
Conversation
- remove ceph packages/testing in fsal gluster builds - Ceph packages are the lastest builds of master from shaman.ceph.com Signed-off-by: Ali Maredia <[email protected]>
What I was getting at with "logging" was how does someone know these tests failed on their patch. I think this would ideally run with a different gerrithub ID so that it can have a separate Verified "vote" on patches. I don't understand how all that magic works though... |
@ffilz This currently has no hooks into the CI yet. This should go in as a new ceph branch, and then we can start on the CI hooks (since the CI needs some place to check out from before it can run). This will have a different ID. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The majority is probably a copy/paste from an other job, which one? There might be similar mistakes in there.
Testing Ceph would be better when there is a Ceph bot account for gerrithub.io. This way we (and Frank!) can see which projects have voted. Reqesting a bot account is relatively easy, send an email to [email protected] (give them a public ssh key) and we can work on adding the bot to the CentOS CI Jenkins instance (through bstinson in #centos-devel on Freenode).
RET=$? | ||
|
||
# exit with SUCCESS or FAIL only | ||
exit ${EXIT}</command> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does ${EXIT}
come from?
# only use https for now | ||
GIT_REPO="https://${GERRIT_HOST}/${GERRIT_PROJECT}" | ||
|
||
SHAMAN_REPO_URL="https://shaman.ceph.com/api/repos/ceph/master/latest/centos/7/flavors/default/repo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use ${CENTOS_VERSION}
instead of 7. CentOS-6 can be provided through the jobs too (and that should probably fail while installing dependencies).
<choices class="java.util.Arrays$ArrayList"> | ||
<a class="string-array"> | ||
<string>7</string> | ||
<string>6</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you want to provide testing for CentOS-6?
<choices class="java.util.Arrays$ArrayList"> | ||
<a class="string-array"> | ||
<string>x86_64</string> | ||
<string>i386</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there i386 compatible RPMs in the shaman repository?
d8d767f
to
cf571a6
Compare
801b37d
to
c770b94
Compare
e9b2ca4
to
a09a2e5
Compare
e93af3b
to
ade304e
Compare
ade304e
to
7be933f
Compare
1a86ec1
to
1ed5d17
Compare
builds
from shaman.ceph.com
Signed-off-by: Ali Maredia [email protected]