Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Skip nf-test on docs changes #1761

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

ci: Skip nf-test on docs changes #1761

wants to merge 2 commits into from
+8 −0

Conversation

edmundmiller
Copy link
Contributor

Skips nf-test on any docs changes.

We can probably cut docs/** if we want to save lines 🙃

@edmundmiller edmundmiller self-assigned this Dec 12, 2024
@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.0.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 85c6c32

+| ✅ 214 tests passed       |+
#| ❔  11 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 3.5.0
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-12-12 21:56:19

maxulysse
maxulysse reviewed Dec 12, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@jfy133
Copy link
Member

jfy133 commented Dec 12, 2024

The tests still ran though, no?

@edmundmiller @maxulysse
Update .github/workflows/ci.yml
85c6c32 
Co-authored-by: Maxime U Garcia <[email protected]>
@edmundmiller
Copy link
Contributor Author

The tests still ran though, no?

This modified a GitHub action yml not a doc 😜

@jfy133
Copy link
Member

jfy133 commented Dec 13, 2024

The tests still ran though, no?

This modified a GitHub action yml not a doc 😜

Oh haha fair, but maybe worth modifying a doc as a test? 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse left review comments

@FriederikeHanssen FriederikeHanssen Awaiting requested review from FriederikeHanssen

@jfy133 jfy133 Awaiting requested review from jfy133

At least 1 approving review is required to merge this pull request.

Assignees

@edmundmiller edmundmiller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edmundmiller @nf-core-bot @jfy133 @maxulysse