Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented TMB score calculation #1738

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Implemented TMB score calculation #1738

wants to merge 4 commits into from

Conversation

bounlu
Copy link
Contributor

@bounlu bounlu commented Nov 20, 2024

Implements #495 based on pyTMB.py starting from draft by @FriederikeHanssen

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 2.14.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@bounlu bounlu closed this Nov 20, 2024
@bounlu bounlu deleted the TMB branch November 20, 2024 06:59
@bounlu bounlu restored the TMB branch November 20, 2024 07:00
@bounlu bounlu reopened this Nov 20, 2024
@FriederikeHanssen
Copy link
Contributor

Amazing 🌟 Looks like this PR also contains the MSISENSOR changes? @Patricie34 is also implementing variant normalisation over in #1682 , can these efforts be combined/ is that implementation something you can build on?

@bounlu
Copy link
Contributor Author

bounlu commented Nov 28, 2024

Yes somehow msisensorpro tumor-only changes also got into this PR and I cannot separate them. I am not sure if I can help with the variant normalization.

@Patricie34
Copy link

Yes somehow msisensorpro tumor-only changes also got into this PR and I cannot separate them. I am not sure if I can help with the variant normalization.

Hi, are you planning to finish this PR? I am almost done with the normalization and since I will need to calculate TMB in near future, it would be great to have it implemented in Sarek!
If you agree I would like to join/help with it.

@bounlu
Copy link
Contributor Author

bounlu commented Dec 18, 2024

Hi. It's already finished on my end. I am using it on my version of sarek and it works fine. Please feel free to modify it to integrate to the current version of the public version.

@Patricie34
Copy link

Hi. It's already finished on my end. I am using it on my version of sarek and it works fine. Please feel free to modify it to integrate to the current version of the public version.

Oh, I see. So you're not planning to resolve the conflicts here so it could be merged? If it works, I could try to finish it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants