-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autocomplete): clear autocomplete value when pressing clear button #4458
Conversation
🦋 Changeset detectedLatest commit: 117310c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe pull request addresses a bug in the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (3)
🔇 Additional comments (3)packages/components/autocomplete/src/use-autocomplete.ts (1)
By calling Would you like to run additional tests to confirm that users do not find the always-open behavior confusing, especially if they simply want to reset the field without continuing to browse options? packages/components/autocomplete/__tests__/autocomplete.test.tsx (1)
The new test ("should clear arbitrary value after clicking clear button") thoroughly ensures that manually-typed input is cleared properly. This improves reliability and user experience by verifying the new clear~functionality. .changeset/nice-books-yell.md (1)
This changeset clearly documents the improvement of clearing the autocomplete value when pressing the clear button, referencing issue #4402. Keeping the changelog concise and descriptive helps maintainers and users understand intentional fixes. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, LGTM!
Closes #4402
📝 Description
Currently you can clear the arbitrary value in autocomplete by pressing clear button only when
allowsCustomValue
is set totrue
. If a user tries to search something, then clicking clear button will not clear the value. This PR is to make autocomplete to clear the value in all cases.⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit
New Features
Bug Fixes
Tests