fix(slider): missing marks when hideThumb is true & revise slider styles

[wingkwong]

Closes #2880

📝 Description

• revise slider styles
• add some tests

⛳️ Current behavior (updates)

with marks specified, when hideThumb is true, all marks will be gone.

🚀 New behavior

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Summary by CodeRabbit

• New Features

  • Enhanced slider component with new configuration options including maxValue, minValue, step, and marks.

• Tests

  • Added new test cases for the Slider component to ensure functionality with features like hidden thumb and display of marks.

• Style

  • Updated slider styling to accommodate different sizes, orientations, and configurations.

• Documentation

  • Updated component stories to demonstrate new slider configurations and default values.

[changeset-bot]

🦋 Changeset detected

Latest commit: 8534c85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@nextui-org/theme	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[linear]

ENG-741 [BUG] - `hideThumbs` prop hides both thumbs and `marks` on Slider component

[coderabbitai]

Walkthrough

The recent changes involve enhancements and bug fixes to the Slider component across different files. New test cases have been added to verify features such as hideThumb and marks. Adjustments have been made to the slider's CSS in the theme package to refine its appearance based on size and orientation. Additionally, story configurations for the slider have been updated to demonstrate new properties like maxValue and minValue.

Changes

File Path	Summary of Changes
.../__tests__/slider.test.tsx	Added test cases for hideThumb, marks, and combined functionality.
.../stories/slider.stories.tsx	Updated ThumbHidden component properties and added new configurations.
.../src/components/slider.ts	Adjusted CSS properties for slider track in various scenarios.
.changeset/eighty-kids-drop.md	Introduced a patch for slider styles in the theme package.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure hideThumbs prop only hides thumbs and not marks [#2880]	❌	The changes do not explicitly address the issue where hideThumbs also hides marks. The test cases and story updates do not clarify if the bug was fixed.

---

Recent Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1a033fe and 8534c85.

Files selected for processing (4)

• .changeset/eighty-kids-drop.md (1 hunks)
• packages/components/slider/tests/slider.test.tsx (1 hunks)
• packages/components/slider/stories/slider.stories.tsx (1 hunks)
• packages/core/theme/src/components/slider.ts (4 hunks)

Files skipped from review due to trivial changes (1)

• packages/core/theme/src/components/slider.ts

Additional comments not posted (5)

.changeset/eighty-kids-drop.md (1)

1-5: The changeset description is clear and effectively communicates the scope of the patch.

packages/components/slider/__tests__/slider.test.tsx (3)

218-224: The test case for hideThumb is well-implemented and effectively checks the correct attribute settings when hideThumb is enabled.

---

226-255: The test case for marks correctly verifies the rendering of mark elements based on the provided marks property.

---

257-290: The test case for marks with hideThumb effectively combines the features to ensure they work in tandem without issues.

packages/components/slider/stories/slider.stories.tsx (1)

318-335: The updates to the ThumbHidden story in Storybook effectively demonstrate the Slider component's behavior with the hideThumb property. The added properties enhance the demonstration and are correctly implemented.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 26, 2024 6:03am
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 26, 2024 6:03am