New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): docs changes #2868
feat(docs): docs changes #2868
Conversation
|
Warning Rate Limit Exceeded@wingkwong has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 31 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe update focuses on enhancing UI components and documentation in a software project. Changes include sorting functions in search components, consistent error messaging in input validations, and state type updates in form components. Documentation improvements cover API references, component guides, and project setup instructions, aiming for better usability and developer guidance. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* docs(guide): add an explanation for the installation guide * docs(guide): add an explanation for the cli guide * docs(guide): add support for cli output
#2881) * chore(calendar): remove showMonthAndYearPickers from range calendar story * docs(date-range-picker): remove showMonthAndYearPickers info * docs(range-calendar): remove unsupported props
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Out of diff range and nitpick comments (4)
apps/docs/content/docs/components/date-range-picker.mdx (4)
Line range hint
5-5
: Ensure the sentence starts with an uppercase letter for consistency.- date Range Picker combines two DateInputs and a RangeCalendar popover to allow users to enter or select a date and time range. + Date Range Picker combines two DateInputs and a RangeCalendar popover to allow users to enter or select a date and time range.
Line range hint
64-64
: Clarify the comma usage before "if" to improve readability.- By default, the calendar popover displays a single month. The `visibleMonths` prop allows displaying up to 3 months at a time, if screen space permits. + By default, the calendar popover displays a single month. The `visibleMonths` prop allows displaying up to 3 months at a time if screen space permits.
Line range hint
285-285
: Capitalize the first letter of the sentence for consistency.- - **base**: base element. it handles alignment, placement, and general appearance. + - **base**: Base element. It handles alignment, placement, and general appearance.
Line range hint
323-323
: Use "an" instead of "a" before words that start with a vowel sound.- When the date-range-picker has a end content. Base on those `endContent` prop. + When the date-range-picker has an end content. Based on those `endContent` prop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Out of diff range and nitpick comments (2)
apps/docs/content/docs/api-references/nextui-provider.mdx (2)
42-42
: Consider using a hyphen in "client side" to form the compound adjective "client-side".The phrase "client side router" should be "client-side router" to correctly form the compound adjective modifying "router".
154-157
: Clarify the interaction betweendisableAnimation
andskipFramerMotionAnimations
properties.The description of how
disableAnimation
interacts withskipFramerMotionAnimations
could be clearer. Consider rephrasing to explicitly state the conditions under which each property affects the animations.
@@ -5,80 +5,167 @@ description: API References for NextUI Provider | |||
|
|||
# NextUI Provider | |||
|
|||
API reference for the `NextUIProvider`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure consistency in the description of the NextUIProvider
.
The description "API reference for the NextUIProvider
." could be expanded to provide more context about what NextUIProvider
does, rather than just stating that this is an API reference.
For example, if your application only supports Gregorian dates, you could implement a `createCalendar` | ||
function like this: | ||
|
||
```tsx | ||
import {GregorianCalendar} from '@internationalized/date'; | ||
|
||
function createCalendar(identifier) { | ||
switch (identifier) { | ||
case 'gregory': | ||
return new GregorianCalendar(); | ||
default: | ||
throw new Error(`Unsupported calendar ${identifier}`); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the createCalendar
function handles all necessary cases.
The createCalendar
function currently only handles the 'gregory' identifier. Consider adding more cases or a default handler to ensure that the function can manage different calendar types if necessary.
Closes #
📝 Description
to be merged to
canary
once the new gitflow is applied⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit
New Features
Bug Fixes
Documentation