fix(input): correct label margin for RTL required inputs

[mrbadri]

Closes #2780

📝 Description

This pull request fixes an issue where the Autocomplete, Textarea, and Input components do not display correctly under RTL configurations when the "required" property is used. The labels are not positioned correctly, which affects the layout.

⛳️ Current behavior (updates)

Currently, in RTL layouts, when the "required" property is set for Autocomplete, Textarea, and Input components, the labels are misaligned. This results in an inconsistent appearance and can lead to a poor user experience.

🚀 New behavior

With this update, the labels in the Autocomplete, Textarea, and Input components are correctly positioned in RTL configurations. This ensures the visual consistency across different text directions and improves the overall interface aesthetics.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

This fix enhances the usability and visual alignment of form elements in RTL layouts, ensuring that NextUI continues to provide a seamless experience for global users with diverse text direction needs.

Summary by CodeRabbit

• Bug Fixes
  • Enhanced visual alignment and consistency by fixing incorrect margin on labels for right-to-left (RTL) required inputs.

[changeset-bot]

🦋 Changeset detected

Latest commit: 0c10c2f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@nextui-org/theme	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 18, 2024 4:59pm

[vercel]

@mrbadri is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

This update addresses a specific bug related to the margin discrepancies in labels for required inputs in RTL layouts. The changes involve enhancing the label property within the isRequired object in the input.ts file by adding additional styling classes and RTL-specific styles.

Changes

File	Change Summary
.changeset/shaggy-cooks-pay.md	Introduced a fix for incorrect margin on RTL required inputs.
packages/core/theme/src/components/input.ts	Expanded label property in isRequired object with additional styling classes and RTL-specific styles.

Assessment against linked issues

Objective	Addressed	Explanation
Proper label positioning in RTL layout for required Autocomplete, Textarea, and Input components (#2780)	✅

Possibly related issues

• Issue [BUG] - Input Alignment and classNames Styling When Using label in Input Component #2651: This issue discusses misalignment and style application problems with labels in the Input component. Although it does not specifically address RTL issues, the changes made in the PR could potentially influence or resolve some aspects of the styling issues described, especially regarding label interactions. Hence, linking this issue might be beneficial for tracking related fixes.

---

Recent Review Details

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between 8a03f03 and 0c10c2f.

Files selected for processing (1)

• .changeset/witty-birds-watch.md (1 hunks)

Additional comments not posted (1)

.changeset/witty-birds-watch.md (1)

1-5: The changeset succinctly summarizes the fix applied to the @nextui-org/theme package, ensuring clarity for future reference. The reference to the issue number enhances traceability.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mrbadri]

Hi @wingkwong,

Thank you for your valuable feedback. I have addressed the comments you provided. Could you please review the changes at your earliest convenience? I appreciate your assistance!

Best regards,
Mohammad Reza Badri