Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] - hideThumbs prop hides both thumbs and marks on Slider component #2880

Closed
hhaste opened this issue Apr 26, 2024 · 1 comment · Fixed by #2883
Closed

[BUG] - hideThumbs prop hides both thumbs and marks on Slider component #2880

hhaste opened this issue Apr 26, 2024 · 1 comment · Fixed by #2883
Assignees
@wingkwong
Labels
📦 Scope : Components Related to the components 🐛 Type: Bug Something isn't working

Comments

@hhaste
Copy link

hhaste commented Apr 26, 2024

NextUI Version

2.3.6

Describe the bug

Passing the hideThumbs prop on the Slider component also hides the labels of any marks.

Your Example Website or App

https://stackblitz.com/edit/nextui-slider-hidethumbs?file=app%2Fpage.tsx

Steps to Reproduce the Bug or Issue

  1. Open the example website
  2. Go to line 9 of app/page.tsx
  3. Pass the hideThumbs prop

Expected behavior

When passing the hideThumbs prop to the Slider component, I expected only the slider thumbs to be hidden, but I am noticing that it also hides any marks that I passed.

Screenshots or Videos

Screenshot.2024-04-25.rc0uIb.mp4

Operating System Version

Windows

Browser

Chrome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wingkwong wingkwong

Labels
📦 Scope : Components Related to the components 🐛 Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(slider): missing marks when hideThumb is true & revise slider styles nextui-org/nextui
2 participants
@wingkwong @hhaste