#5823 add responseStatusCode #6170
Conversation
|
@rogin hopefully a quick question does |
|
@ARShelleyNextGen and @JackieK5 this is a good one line PR that makes Mirth easier to use. Would it be possible to merge it for 4.6.0? |
It's been awhile, but IIRC it returned "200". |
| @@ -335,6 +335,7 @@ public Response send(ConnectorProperties connectorProperties, ConnectorMessage c | |||
| list.add(header.getValue()); | |||
| } | |||
|
|
|||
| connectorMessage.getConnectorMap().put("responseStatusCode", String.valueOf(statusCode)); | |||
There was a problem hiding this comment.
I think my preference would be to leave it as an int rather than converting it to a String. It is a numerical value, after all.
It won't have the issue with velocity adding the .0 that @jonbartels alluded to because java auto-boxing will store it as a java.lang.Integer rather than a java.lang.Double as it would be if you put a JavaScript number into the map.
There was a problem hiding this comment.
I agree that the statusCode should probably be left as an int.
There was a problem hiding this comment.
Well sure...would want to do response code comparisons by integer ranges anyway.
200s are OK
300s are redirects.
400s are errors
etc
pladesma
changed the base branch from
development
to
pr-6170-add-status-code-to-connector-map
pladesma
merged commit 3dcc058
into
nextgenhealthcare:pr-6170-add-status-code-to-connector-map
resolves #5823
Store the HTTP status code in the Response Map