fix(freebsd): fix cpu count for load graph #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConstrictM
force-pushed
the
bugfix-freebsdcpuviewer
branch
from
2bd7827 to
a99fbf3
Compare
joshtrichards
approved these changes
Jan 18, 2025
| } catch (RuntimeException) { | ||
| return $numCpu; |
There was a problem hiding this comment.
Suggested change
| return $numCpu; |
Should be unnecessary since we're pre-initializing $numCpu and returning it anyhow at the end of the function, but also doesn't hurt. I see we're doing this elsewhere already so I guess leave it.
There was a problem hiding this comment.
That was my thought process. It should be consistent with the rest. Or all of the exception returns should be removed.
|
Can you edit your commit message? We're using conventional commits through more of our repositories these days. The requirement was recently activated here in this one too. |
Signed-off-by: Matthew Wener <[email protected]>
ConstrictM
force-pushed
the
bugfix-freebsdcpuviewer
branch
from
a99fbf3 to
61f1b20
Compare
ConstrictM
changed the title
joshtrichards
approved these changes
Jan 18, 2025
|
/backport to stable30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #711
Nextcloud version: 30.0.5
FreeBSD is showing "CPU info not available". The reason is the CPU count function is not calling the command correctly.
Fix Tested:
