Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add size of appdata folder to statistics #728

Merged
merged 3 commits into from
Jan 18, 2025

Conversation

tcitworld
Copy link
Member

App data is used for a lot of things and the preview folder especially can grow very much. This helps identifying where storage growth comes from.

Also refactor to use IAppConfig in related files.

App data is used for a lot of things and the preview folder especially can grow very much. This
helps identifying where storage growth comes from.

Signed-off-by: Thomas Citharel <[email protected]>
@nickvergessen
Copy link
Member

@nickvergessen nickvergessen removed their request for review January 7, 2025 19:11
@tcitworld
Copy link
Member Author

@JuliaKirschenheuter @kesselb why are you code owners only on the /appinfo/info.xml file and not on everything? I didn't have the reflex to check that.

@nickvergessen
Copy link
Member

why are you code owners only on the /appinfo/info.xml file

To keep the notifications manageable, but they are still supposed to respond to issues and PRs regularly.

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filecount would be useful as well, no?
On my personal instance the issue with previews was the number of files cluttering oc_filecache because of leftover previews.

@tcitworld
Copy link
Member Author

I can add this, yes.

@tcitworld tcitworld requested a review from come-nc January 17, 2025 17:28
@kesselb kesselb merged commit 67dfe66 into master Jan 18, 2025
39 checks passed
@kesselb kesselb deleted the storage-statistics branch January 18, 2025 22:10
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants