fix: Display threads and not cores #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <[email protected]>
|
/backport to stable29 |
|
/backport to stable28 |
kesselb
approved these changes
Aug 12, 2024
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Linux I verified this is correct, but I'm not able to test this on FreeBSD. I'm relatively sure though that the variable that is read is also the thread count and not the core count.
While trying to find documentation for the sysctl variable I read https://man.freebsd.org/cgi/man.cgi?smp(4) and it seems we should switch to
hw.ncpusince that is at least documented (and if I understood correctly it is also the thread count and not the core count).On that note it might be nice to show both the number of threads and cores and not only one of them. FreeBSD also has some other variables related to threads per core, but with the recent changes on processor topologies it seems worthless to me to use that since not every core is guaranteed to have the same number of threads...