Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(neon): make NeonPlatform an interface #478

Closed
wants to merge 1 commit into from
Closed

refactor(neon): make NeonPlatform an interface #478

wants to merge 1 commit into from

Conversation

Leptopoda
Copy link
Member

No description provided.

@Leptopoda
Copy link
Member Author

Leptopoda commented Jul 15, 2023 •
edited
Loading

@provokateurin Looks like ci doesn't like PRs from a fork :)

@provokateurin
Copy link
Member

Ah shit I think the conventional commits CI doesn't work for forks

@provokateurin
Copy link
Member

Also your branch name is wrong

@provokateurin
Copy link
Member

Reopened hyiso/commitlint#7

@Leptopoda
Copy link
Member Author

Also your branch name is wrong

So the branch name will also be linted? So refactor/neon_platform or what?

@provokateurin
Copy link
Member

No the branch name is not linted, I just noticed that the branch name is wrong for this PR

@Leptopoda Leptopoda mentioned this pull request Jul 15, 2023
Merged
@Leptopoda Leptopoda closed this Jul 15, 2023
@Leptopoda Leptopoda deleted the deps/wakelok_plus branch July 15, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leptopoda @provokateurin