fix(NcAppNavigationItem): Fix popper boundary element #5632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
added
bug
|
I end up in the same scenario as you. I can reproduce the issue on main, then i link and the issue is gone. I do npm ci, kill the link and same as you i cannot reproduce it anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
The query selector in the computed prop ran too early, before the element existed. There is no reactivity. Now the boundary element is set very late at mount, when the boundary element does exist in the DOM.
There are a few edge cases, but the menu positions better than before when the boundary fell back to the
body.🖼️ Screenshots
🚧 Tasks
🏁 Checklist
nextrequested with a Vue 3 upgrade