Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: sveltekit demo refactor #12287

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ganxiaozhe
Copy link

☕️ Reasoning

This PR focuses on improving the UI/UX of the SvelteKit example app under ./apps/examples/sveltekit/. The changes include:

  • Refactored and modernized the overall UI design
  • Enhanced user experience and interaction flows
  • Improved responsive layouts and components
  • Updated styling to better match NextAuth.js branding
  • Optimized code structure and organization

These changes aim to provide a better demonstration of NextAuth.js integration with SvelteKit, making it easier for developers to understand and implement authentication in their SvelteKit applications.

🧢 Checklist

  • Documentation
    • Added explanatory notes for key implementation details
  • Tests
    • Manually tested all UI components and interactions
    • Verified authentication flows work as expected
  • Ready to be merged

🎫 Affected issues

This PR primarily focuses on improving the example implementation rather than fixing specific issues. However, it indirectly helps with better documentation and demonstration of NextAuth.js with SvelteKit.

📌 Resources

I have reviewed and followed:

Preview

CleanShot 2024-11-24 at 15 06 19@2x

Copy link

vercel bot commented Nov 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ❌ Failed (Inspect) Nov 24, 2024 7:08am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2024 7:08am

Copy link

vercel bot commented Nov 24, 2024

@ganxiaozhe is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@auth/[email protected] Transitive: network +1 1.89 MB balazsorban
npm/@eslint/[email protected] None 0 47.7 kB eslintbot
npm/@eslint/[email protected] None 0 14.2 kB eslintbot
npm/@graphql-codegen/[email protected] environment, filesystem, network, shell, unsafe +54 14.5 MB dotansimha
npm/@graphql-codegen/[email protected] Transitive: environment, eval, filesystem, shell, unsafe +43 16.3 MB dotansimha
npm/@graphql-typed-document-node/[email protected] None 0 2.96 kB dotansimha
npm/@inkeep/[email protected] Transitive: environment, filesystem, network, shell, unsafe +28 22.2 MB sarah-inkeep
npm/@mikro-orm/[email protected] environment, eval, filesystem, unsafe 0 888 kB b4nan
npm/@mikro-orm/[email protected] filesystem +1 354 kB b4nan
npm/@miniflare/[email protected] filesystem, unsafe Transitive: environment, eval, network, shell +5 460 kB wrangler-publisher
npm/@next/[email protected] None 0 14.2 kB vercel-release-bot
npm/@tailwindcss/[email protected] None +6 382 kB adamwathan
npm/[email protected] None +10 5.08 MB huntabyte
npm/[email protected] None 0 32.8 kB huntabyte
npm/[email protected] None 0 1.68 MB shinichiokada
npm/[email protected] None 0 712 kB dcas
npm/[email protected] None 0 42.7 kB juniorgarciadev
npm/[email protected] environment, eval, filesystem, network, shell, unsafe 0 3.26 MB vitebot

🚮 Removed packages: npm/@auth/[email protected], npm/@auth/[email protected], npm/@radix-ui/[email protected], npm/@radix-ui/[email protected], npm/@radix-ui/[email protected], npm/@radix-ui/[email protected], npm/@radix-ui/[email protected], npm/@simplewebauthn/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@vercel/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@ndom91
Copy link
Member

ndom91 commented Nov 26, 2024

This is awesome, thanks!

1 request though, can we use runes in the svelte components? I believe I saw bits-ui release a svelte-5 compatible version recently, so shadcn-svelte should be compatible, no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants