-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: sveltekit demo refactor #12287
Open
ganxiaozhe
wants to merge
3
commits into
nextauthjs:main
Choose a base branch
from
ganxiaozhe:feat/sveltekit-demo-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature: sveltekit demo refactor #12287
ganxiaozhe
wants to merge
3
commits into
nextauthjs:main
from
ganxiaozhe:feat/sveltekit-demo-refactor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganxiaozhe
requested review from
ubbe-xyz,
ndom91,
ThangHuuVu and
balazsorban44
as code owners
November 24, 2024 07:08
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@ganxiaozhe is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
This is awesome, thanks! 1 request though, can we use runes in the svelte components? I believe I saw bits-ui release a svelte-5 compatible version recently, so shadcn-svelte should be compatible, no |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
This PR focuses on improving the UI/UX of the SvelteKit example app under
./apps/examples/sveltekit/
. The changes include:These changes aim to provide a better demonstration of NextAuth.js integration with SvelteKit, making it easier for developers to understand and implement authentication in their SvelteKit applications.
🧢 Checklist
🎫 Affected issues
This PR primarily focuses on improving the example implementation rather than fixing specific issues. However, it indirectly helps with better documentation and demonstration of NextAuth.js with SvelteKit.
📌 Resources
I have reviewed and followed:
Preview