Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(adapters): cleanup sqlite3 + better-sqlite3 for libsql #10813

Merged
merged 16 commits into from May 9, 2024

Conversation

ndom91
Copy link
Member

@ndom91 ndom91 commented May 4, 2024

☕️ Reasoning

  • Cleanup all instances of sqlite3 and better-sqlite3 for libsql, which is a JS-based better-sqlite3-API compatible sqlite client from the Turso folks, i.e. we don't need node-gyp and it can run on the edge.
    • This also makes it easier / possible for more folks to install the deps and work on the repo, for example.
  • This is an API-compatible lib change for libs we only used in devDependencies, so its not breaking anything in the shipped pkgs. All tests still pass 🙏

Notes

  • D1 can't use libsql (yet) due to D1 using the bind fn from better-sqlite3, which libsql hasn't implemented

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented May 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 10:58am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 10:58am
proxy ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 10:58am

@github-actions github-actions bot added adapters Changes related to the core code concerning database adapters typeorm @auth/typeorm-adapter labels May 4, 2024
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.48%. Comparing base (5bd3043) to head (d0325d0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10813   +/-   ##
=======================================
  Coverage   37.48%   37.48%           
=======================================
  Files         173      173           
  Lines       27026    27026           
  Branches     1174     1174           
=======================================
  Hits        10131    10131           
  Misses      16895    16895           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 4, 2024

Broken Link Checker

0 broken links found. Links organised below by source page, or page where they were found.

@github-actions github-actions bot added the d1 label May 6, 2024
@ndom91 ndom91 changed the title chore: cleanup sqlite3 for better-sqlite3 chore(adapters): cleanup sqlite3 for better-sqlite3 May 9, 2024
@ndom91 ndom91 changed the title chore(adapters): cleanup sqlite3 for better-sqlite3 chore(adapters): cleanup sqlite3 + better-sqlite3 for libsql May 9, 2024
@ndom91 ndom91 merged commit 05a5cc7 into main May 9, 2024
14 of 15 checks passed
@ndom91 ndom91 deleted the ndom91/better-sqlite3-cleanup branch May 9, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters Changes related to the core code concerning database adapters d1 drizzle @auth/drizzle-adapter kysely typeorm @auth/typeorm-adapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant