4단계 - 자동차 경주(우승자) #5104
Open
4단계 - 자동차 경주(우승자) #5104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingbingpa
requested changes
Nov 13, 2023
Comment on lines
+11
to
+16
|
|
||
|
|
||
|
|
||
| List<Car> cars = new ArrayList<>(names.length); | ||
| for (String name : names) { | ||
| validateName(name); |
Comment on lines
+10
to
+11
| private ResultView() { | ||
| } |
There was a problem hiding this comment.
인스턴스가 없고, static method 만 있는 클래스들에 동일하게 적용해보는건 어떨까요?
InputView 는 인스턴스를 생성하고, ResultView 는 인스턴스 생성 없이 쓰고 있네요.
CarFactory 또한 일종의 팩토리 메소드 같은데요. createCars 를 통해 생성하도록 기본 생성자는 사용못하도록 하는건 어떨까요?
| } | ||
|
|
||
| public List<Car> start() { | ||
| System.out.println("실행 결과"); |
|
|
||
| private void validateName(String name) { | ||
| if (name.length() > MAX_NAME_SIZE) { | ||
| throw new RuntimeException(); |
There was a problem hiding this comment.
RuntimeException 보다는 조금 더 명확한 익셉션이나 커스텀한 익셉션을 만들어 사용하는건 어떨까요?
그리고 왜 에러가 발생했는지 메시지를 조금 더 명확하게 주면 좋을 것 같아요.
|
|
||
| @DisplayName("자동차의 이름은 5자를 초과할 수 없다") | ||
| @Test | ||
| void test2() { |
|
|
||
| @DisplayName("우승자를 선정한다 우승자는 1명 이상이다.") | ||
| @Test | ||
| void test3() { |
There was a problem hiding this comment.
테스트의 검증이 조금 모호한 것 같아요.
실제 racing 을 의도한 대로 수행하고 예측한 자동차가 우승자로 선정되는지를 판별하는건 어떨까요?
| @@ -0,0 +1,48 @@ | |||
| package step4.domain; | |||
|
|
|||
| public class Car { | |||
|
|
||
| public class NumberUtil { | ||
| public static int createRandomNumber() { | ||
| return (int) (Math.random() * 10); |
There was a problem hiding this comment.
캐스팅 없이도 난수를 생성 할 수 있지 않을까요?
난수 생성에 대해서도 간단하지만 테스트를 해보면 좋을 것 같아요.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4단계 제출합니다.