Step3 Step4 merger 입니다. #4697
Open
Step3 Step4 merger 입니다. #4697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testrace
requested changes
May 1, 2023
Comment on lines
+42
to
+44
| public String findWinnerCar() { | ||
| return ""; | ||
| } |
Comment on lines
+9
to
+15
| public static void main(String[] args) { | ||
| Scanner scanner = new Scanner(System.in); | ||
| String carNames = scanner.nextLine(); | ||
| int moveCount = scanner.nextInt(); | ||
| WinnerRacingCar racingCar = new WinnerRacingCar(); | ||
| racingCar.race(racingCar.makeRacingCar(carNames), moveCount); | ||
| } |
There was a problem hiding this comment.
RacingCar, WinnerRacingcar 두 클래스 모두 main 메서드가 있네요 🤔
main메서드는 단계별로 추가하실 필요는 없을 것 같아요
Comment on lines
+31
to
+38
| public List<Car> makeRacingCar(String carNames) { | ||
| String[] carNameArray = carNames.split(","); | ||
| ArrayList<Car> cars = new ArrayList<>(); | ||
| for (int i = 0; i <carNameArray.length ; i++) { | ||
| cars.add(new Car(carNameArray[i])); | ||
| } | ||
| return cars; | ||
| } |
There was a problem hiding this comment.
위 코멘트와 마찬가지로 3단계, 4단계 별도로 구현하실 필요 없이 최종 단계의 코드만 남겨주세요
단계별로 요구사항이 추가/변경 되기 때문에 지난 단계의 코드를 따로 남겨두실 필요는 없을 것 같아요
Comment on lines
+28
to
+32
| @Test | ||
| void 전진하는조건은0에서9사이에서random값을구한후_random값이4이상일경우이다() { | ||
| Car car = new Car("car", 0); | ||
| car.move(); | ||
| } |
There was a problem hiding this comment.
자동차가 움직였다/움직이지 않았다 라는 사실을 검증하기 위해 assert 문이 필요하지 않을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.