Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes macOS signing in the same way that pkg does.
Which issue(s) this PR fixes:
Fixes #446
Special notes for your reviewer:
I've tested these steps manually (using ldid to try the signing step),
but haven't tested them as part of the nexe codebase as I don't have access to a mac...got some access :-) All working here :-)The impl isn't using any streaming or any such, but the binary shouldn't be big enough to cause any real memory pressure I'd have thought? But perhaps it could be tweaked to work via streams or similar, for now I just wanted to create the draft PR in case it can help others :-) (And perhaps cleanup is a later thing? 馃し :-) )
Until it's releasable, something akin to the following would work as a workaround:
build.js
or, if done via the command line: