devcontainer: Base python 3.10.2 devcontainer #2880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use VSCode devcontainer infrastructure to allow remote or containerized development to avoid install multiple depenencied on host machine Installed: - python 3.10.2 ( base official Docker image on debian Bullseye ) - Puppet PDK - PHP 7.4 Signed-off-by: Helio Chissini de Castro <[email protected]>
- Avoid use configure. As we are inside container using non-root user, there's no necessity to add an extra virtualenv, so we are installing dependencies using pip requirements. - Add sudo capacity to container - Remove pdk and php for now. There's no immediate reason to have it and introduce it was a mistake on beginning Signed-off-by: Helio Chissini de Castro <[email protected]>
|
@heliocastro Thank you++ |
pombredanne
reviewed
Mar 4, 2022
| // "puppet.puppet-vscode", | ||
| ], | ||
| // "postCreateCommand": "./configure --dev", | ||
| "postStartCommand": "pip install -r requirements.txt -r requirements-dev.txt" |
There was a problem hiding this comment.
This may not be the best command. We use these only as constraints and no longer as plain requirements. See
Line 28 in 1dc4b61
So IMHO running configure --dev (on all OSes) would be a better option.
|
I tried, but then this happens, even if i go up to python 3.8. The repos on aboutcode are somehow not behaving properly: INFO: pip is looking at multiple versions of scancode-toolkit to determine which version is compatible with other requirements. This could take a while.
INFO: pip is looking at multiple versions of scancode-toolkit[packages] to determine which version is compatible with other requirements. This could take a while.
INFO: pip is looking at multiple versions of scancode-toolkit[dev] to determine which version is compatible with other requirements. This could take a while.
ERROR: Could not find a version that satisfies the requirement setuptools>=40.0 (from pytest-rerunfailures)
ERROR: No matching distribution found for setuptools>=40.0
Traceback (most recent call last):
File "/workspaces/scancode-toolkit/etc/configure.py", line 76, in call
subprocess.check_call(
File "/usr/local/lib/python3.10/subprocess.py", line 369, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '"/workspaces/scancode-toolkit/bin/pip" install --upgrade --no-build-isolation --no-index --find-links https://thirdparty.aboutcode.org/pypi --editable .[dev] --editable .[packages] --constraint requirements.txt --constraint requirements-dev.txt' returned non-zero exit status 1.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/workspaces/scancode-toolkit/etc/configure.py", line 331, in <module>
pip_install(requirement_args, quiet=quiet)
File "/workspaces/scancode-toolkit/etc/configure.py", line 216, in pip_install
call(cmd)
File "/workspaces/scancode-toolkit/etc/configure.py", line 84, in call
raise Exception('Failed to run {}\n{}'.format(cmd, str(e)))
Exception: Failed to run "/workspaces/scancode-toolkit/bin/pip" install --upgrade --no-build-isolation --no-index --find-links https://thirdparty.aboutcode.org/pypi --editable .[dev] --editable .[packages] --constraint requirements.txt --constraint requirements-dev.txt
Command '"/workspaces/scancode-toolkit/bin/pip" install --upgrade --no-build-isolation --no-index --find-links https://thirdparty.aboutcode.org/pypi --editable .[dev] --editable .[packages] --constraint requirements.txt --constraint requirements-dev.txt' returned non-zero exit status 1.
[142841 ms] postStartCommand failed with exit code 1. Skipping any further user-provided commands. |
pombredanne
reviewed
Jul 29, 2022
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Install common python tools for development | ||
| RUN pip install \ |
There was a problem hiding this comment.
Do we really need all of these? The minimal set of development tools in use are otherwise included in the [tests]extra and installed with ./configure --dev
There was a problem hiding this comment.
We do if we are still relying on PIP as considering some packages will need to handle python wheel buildings.
As i heard you are working on an pip-less env, maybe this is not needed anymore
pombredanne
reviewed
Jul 29, 2022
| "dockerfile": "Dockerfile", | ||
| }, | ||
| "settings": { | ||
| "puppet.installType": "pdk", |
There was a problem hiding this comment.
Is puppet part of the environment?
This should be fixed now with the 31.x release. |
pombredanne
reviewed
Aug 18, 2022
| "editor.formatOnSave": true, | ||
| }, | ||
| // Add the IDs of extensions you want installed when the container is created. | ||
| "extensions": [ |
There was a problem hiding this comment.
are these specific to a developer's local setup?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use VSCode devcontainer infrastructure to allow remote or containerized
development to avoid install multiple depenencies on host machine
Installed:
Signed-off-by: Helio Chissini de Castro [email protected]