Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add d2d option in purlcli #429

Merged
merged 5 commits into from
May 31, 2024
Merged

Add d2d option in purlcli #429

merged 5 commits into from
May 31, 2024

Conversation

TG1999
Copy link
Member

@TG1999 TG1999 commented May 9, 2024 •
edited

Depends on #428

@TG1999 TG1999 marked this pull request as draft May 9, 2024 11:18
@TG1999
Fix tests
35f6130 
Signed-off-by: Tushar Goel <[email protected]>
@TG1999
Refactored purlCLI
05bf6f8 
Signed-off-by: Tushar Goel <[email protected]>
@TG1999 TG1999 marked this pull request as ready for review May 31, 2024 07:52
pombredanne
pombredanne approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!
Note that you can ignore the failing test as I fixed it in main and this will go away once you merge

@TG1999 TG1999 merged commit 27b01a9 into main May 31, 2024
6 of 8 checks passed
@TG1999 TG1999 deleted the d2d_in_purlcli branch May 31, 2024 10:51
@TG1999 TG1999 mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TG1999 @pombredanne